Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last modified on each guide page #419

Merged
merged 7 commits into from
Jul 10, 2020
Merged

Last modified on each guide page #419

merged 7 commits into from
Jul 10, 2020

Conversation

caylahamann
Copy link
Contributor

@caylahamann caylahamann commented Jul 9, 2020

Description

Adds a last updated to each guide page

Reviewer Notes

Look at any of the guide pages!

Related Issue(s) / Ticket(s)

Close #317

Screenshot(s)

Screen Shot 2020-07-09 at 4 20 01 PM

Screen Shot 2020-07-09 at 4 19 49 PM

@caylahamann caylahamann changed the title Cayla/last updated Last modified on each guide page Jul 9, 2020
@caylahamann caylahamann added the work in progress This is work that is not yet ready for review label Jul 10, 2020
@caylahamann caylahamann added enhancement New feature or request and removed work in progress This is work that is not yet ready for review labels Jul 10, 2020
Copy link
Contributor

@zstix zstix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me!

That said, I'm curious how this scales. We're spinning up a subprocess for every Mdx node. Probably something we should keep an eye on.

@caylahamann caylahamann merged commit 5611251 into master Jul 10, 2020
@nr-opensource-bot
Copy link
Contributor

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@caylahamann caylahamann deleted the cayla/last-updated branch July 10, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide last update on each page of the DevEx Site
3 participants