Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide last update on each page of the DevEx Site #317

Closed
caylahamann opened this issue Jun 29, 2020 · 7 comments · Fixed by #419
Closed

Provide last update on each page of the DevEx Site #317

caylahamann opened this issue Jun 29, 2020 · 7 comments · Fixed by #419
Assignees
Labels
enhancement New feature or request released sp:3 Story Point(s): 3

Comments

@caylahamann
Copy link
Contributor

caylahamann commented Jun 29, 2020

Description

As a user I would like to know when a page was last updated so it’s clear to me the recent update of content.

Acceptance Criteria

  • a new section is added to the bottom of the page above the site footer
  • add page last modified {month, day, year} to each page on the site. this indicates the last time the page was updated
@caylahamann caylahamann added the enhancement New feature or request label Jun 29, 2020
@caylahamann caylahamann added this to the Post release fixes milestone Jun 29, 2020
@caylahamann caylahamann added the sp:3 Story Point(s): 3 label Jun 30, 2020
@caylahamann caylahamann self-assigned this Jul 7, 2020
@caylahamann
Copy link
Contributor Author

@djsauble do you have any ideas for the design of this? I would assume it's on every page in the footer

@djsauble
Copy link
Contributor

djsauble commented Jul 8, 2020

I spent a few minutes playing with this. One thing we could do is differentiate between page-specific actions (e.g. edit this page, view history) above the footer separator and general actions (e.g. terms of service, create an issue) below the footer separator. In particular, "View history" is new but would link to the latest diff of the current page on GitHub (I added because it looked a bit bare to only have the "Edit this page" action above the separator, but we could skip if it's too difficult to implement or if @jpvajda disagrees).

image

@jpvajda
Copy link
Contributor

jpvajda commented Jul 8, 2020

@djsauble If view history isn't a lot of effort I think it's cool to have it especially for guides, as if they have a version that someone may have been using, perhaps they'd want to look at an older version of the page.

@jpvajda
Copy link
Contributor

jpvajda commented Jul 8, 2020

Daniel and I decided to just go with the page last modified time stamp after we discussed this.

@djsauble
Copy link
Contributor

djsauble commented Jul 8, 2020

Updated mock

Screen Shot 2020-07-08 at 9 54 33 AM

@caylahamann
Copy link
Contributor Author

@djsauble thank you! Implementing this now :)

@nr-opensource-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released sp:3 Story Point(s): 3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants