Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow begin to process Unregisters without Registers #1542

Merged

Conversation

NikitaSkrynnik
Copy link
Contributor

@NikitaSkrynnik NikitaSkrynnik commented Oct 30, 2023

Description

Allow begin process Unregisters events without Register events. Also added several benchmark tests and test for checking FIFO sequence of Register and Unregister events in begin.

Issue link

networkservicemesh/sdk-k8s#456
#1515

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@NikitaSkrynnik NikitaSkrynnik changed the title Allow begin process Unregisters without Registers Allow begin to process Unregisters without Registers Oct 30, 2023
Signed-off-by: Nikita Skrynnik <[email protected]>
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@02ca02e). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1542   +/-   ##
=======================================
  Coverage        ?   66.97%           
=======================================
  Files           ?      259           
  Lines           ?    12322           
  Branches        ?        0           
=======================================
  Hits            ?     8253           
  Misses          ?     3551           
  Partials        ?      518           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Nikita Skrynnik <[email protected]>
Signed-off-by: Nikita Skrynnik <[email protected]>
Signed-off-by: Nikita Skrynnik <[email protected]>
Signed-off-by: Nikita Skrynnik <[email protected]>
Signed-off-by: Nikita Skrynnik <[email protected]>
Signed-off-by: Nikita Skrynnik <[email protected]>
Signed-off-by: Nikita Skrynnik <[email protected]>
Signed-off-by: Nikita Skrynnik <[email protected]>
Signed-off-by: Nikita Skrynnik <[email protected]>
Signed-off-by: Nikita Skrynnik <[email protected]>
Signed-off-by: Nikita Skrynnik <[email protected]>
Signed-off-by: Nikita Skrynnik <[email protected]>
Signed-off-by: Nikita Skrynnik <[email protected]>
Signed-off-by: Nikita Skrynnik <[email protected]>
Signed-off-by: Nikita Skrynnik <[email protected]>
Signed-off-by: Nikita Skrynnik <[email protected]>
Signed-off-by: Nikita Skrynnik <[email protected]>
Signed-off-by: Nikita Skrynnik <[email protected]>
@NikitaSkrynnik NikitaSkrynnik marked this pull request as ready for review October 31, 2023 14:11
Signed-off-by: Nikita Skrynnik <[email protected]>
@denis-tingaikin denis-tingaikin merged commit 20150d6 into networkservicemesh:main Nov 8, 2023
17 checks passed
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Nov 8, 2023
…k@main

PR link: networkservicemesh/sdk#1542

Commit: 20150d6
Author: Nikita Skrynnik
Date: 2023-11-08 16:52:52 +0700
Message:
  - Allow begin to process Unregisters without Registers (#1542)
* Allow begin process Unregisters without Registers

Signed-off-by: Nikita Skrynnik <[email protected]>

* delete one test + fix go leaks

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix test using mutexes

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix more unit tests

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix some tests + fix linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* test StressTest for begin server

Signed-off-by: Nikita Skrynnik <[email protected]>

* delete unneseccary test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix dial chain element to fix test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* minor fix

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* test again

Signed-off-by: Nikita Skrynnik <[email protected]>

* test again

Signed-off-by: Nikita Skrynnik <[email protected]>

* disable one test

Signed-off-by: Nikita Skrynnik <[email protected]>

* add some logs

Signed-off-by: Nikita Skrynnik <[email protected]>

* add more logs

Signed-off-by: Nikita Skrynnik <[email protected]>

* reduce count of events to 10

Signed-off-by: Nikita Skrynnik <[email protected]>

* skip fifo test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix golang linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* apply some review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix review comments related to dial

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix more review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

---------

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Nov 8, 2023
…k@main

PR link: networkservicemesh/sdk#1542

Commit: 20150d6
Author: Nikita Skrynnik
Date: 2023-11-08 16:52:52 +0700
Message:
  - Allow begin to process Unregisters without Registers (#1542)
* Allow begin process Unregisters without Registers

Signed-off-by: Nikita Skrynnik <[email protected]>

* delete one test + fix go leaks

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix test using mutexes

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix more unit tests

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix some tests + fix linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* test StressTest for begin server

Signed-off-by: Nikita Skrynnik <[email protected]>

* delete unneseccary test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix dial chain element to fix test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* minor fix

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* test again

Signed-off-by: Nikita Skrynnik <[email protected]>

* test again

Signed-off-by: Nikita Skrynnik <[email protected]>

* disable one test

Signed-off-by: Nikita Skrynnik <[email protected]>

* add some logs

Signed-off-by: Nikita Skrynnik <[email protected]>

* add more logs

Signed-off-by: Nikita Skrynnik <[email protected]>

* reduce count of events to 10

Signed-off-by: Nikita Skrynnik <[email protected]>

* skip fifo test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix golang linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* apply some review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix review comments related to dial

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix more review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

---------

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Nov 8, 2023
…k@main

PR link: networkservicemesh/sdk#1542

Commit: 20150d6
Author: Nikita Skrynnik
Date: 2023-11-08 16:52:52 +0700
Message:
  - Allow begin to process Unregisters without Registers (#1542)
* Allow begin process Unregisters without Registers

Signed-off-by: Nikita Skrynnik <[email protected]>

* delete one test + fix go leaks

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix test using mutexes

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix more unit tests

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix some tests + fix linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* test StressTest for begin server

Signed-off-by: Nikita Skrynnik <[email protected]>

* delete unneseccary test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix dial chain element to fix test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* minor fix

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* test again

Signed-off-by: Nikita Skrynnik <[email protected]>

* test again

Signed-off-by: Nikita Skrynnik <[email protected]>

* disable one test

Signed-off-by: Nikita Skrynnik <[email protected]>

* add some logs

Signed-off-by: Nikita Skrynnik <[email protected]>

* add more logs

Signed-off-by: Nikita Skrynnik <[email protected]>

* reduce count of events to 10

Signed-off-by: Nikita Skrynnik <[email protected]>

* skip fifo test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix golang linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* apply some review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix review comments related to dial

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix more review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

---------

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-csi-driver that referenced this pull request Nov 8, 2023
…k@main

PR link: networkservicemesh/sdk#1542

Commit: 20150d6
Author: Nikita Skrynnik
Date: 2023-11-08 16:52:52 +0700
Message:
  - Allow begin to process Unregisters without Registers (#1542)
* Allow begin process Unregisters without Registers

Signed-off-by: Nikita Skrynnik <[email protected]>

* delete one test + fix go leaks

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix test using mutexes

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix more unit tests

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix some tests + fix linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* test StressTest for begin server

Signed-off-by: Nikita Skrynnik <[email protected]>

* delete unneseccary test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix dial chain element to fix test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* minor fix

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* test again

Signed-off-by: Nikita Skrynnik <[email protected]>

* test again

Signed-off-by: Nikita Skrynnik <[email protected]>

* disable one test

Signed-off-by: Nikita Skrynnik <[email protected]>

* add some logs

Signed-off-by: Nikita Skrynnik <[email protected]>

* add more logs

Signed-off-by: Nikita Skrynnik <[email protected]>

* reduce count of events to 10

Signed-off-by: Nikita Skrynnik <[email protected]>

* skip fifo test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix golang linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* apply some review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix review comments related to dial

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix more review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

---------

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Nov 8, 2023
…k@main

PR link: networkservicemesh/sdk#1542

Commit: 20150d6
Author: Nikita Skrynnik
Date: 2023-11-08 16:52:52 +0700
Message:
  - Allow begin to process Unregisters without Registers (#1542)
* Allow begin process Unregisters without Registers

Signed-off-by: Nikita Skrynnik <[email protected]>

* delete one test + fix go leaks

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix test using mutexes

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix more unit tests

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix some tests + fix linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* test StressTest for begin server

Signed-off-by: Nikita Skrynnik <[email protected]>

* delete unneseccary test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix dial chain element to fix test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* minor fix

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* test again

Signed-off-by: Nikita Skrynnik <[email protected]>

* test again

Signed-off-by: Nikita Skrynnik <[email protected]>

* disable one test

Signed-off-by: Nikita Skrynnik <[email protected]>

* add some logs

Signed-off-by: Nikita Skrynnik <[email protected]>

* add more logs

Signed-off-by: Nikita Skrynnik <[email protected]>

* reduce count of events to 10

Signed-off-by: Nikita Skrynnik <[email protected]>

* skip fifo test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix golang linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* apply some review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix review comments related to dial

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix more review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

---------

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Nov 8, 2023
…k@main

PR link: networkservicemesh/sdk#1542

Commit: 20150d6
Author: Nikita Skrynnik
Date: 2023-11-08 16:52:52 +0700
Message:
  - Allow begin to process Unregisters without Registers (#1542)
* Allow begin process Unregisters without Registers

Signed-off-by: Nikita Skrynnik <[email protected]>

* delete one test + fix go leaks

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix test using mutexes

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix more unit tests

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix some tests + fix linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* test StressTest for begin server

Signed-off-by: Nikita Skrynnik <[email protected]>

* delete unneseccary test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix dial chain element to fix test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* minor fix

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* test again

Signed-off-by: Nikita Skrynnik <[email protected]>

* test again

Signed-off-by: Nikita Skrynnik <[email protected]>

* disable one test

Signed-off-by: Nikita Skrynnik <[email protected]>

* add some logs

Signed-off-by: Nikita Skrynnik <[email protected]>

* add more logs

Signed-off-by: Nikita Skrynnik <[email protected]>

* reduce count of events to 10

Signed-off-by: Nikita Skrynnik <[email protected]>

* skip fifo test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix golang linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* apply some review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix review comments related to dial

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix more review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

---------

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Nov 8, 2023
…k@main

PR link: networkservicemesh/sdk#1542

Commit: 20150d6
Author: Nikita Skrynnik
Date: 2023-11-08 16:52:52 +0700
Message:
  - Allow begin to process Unregisters without Registers (#1542)
* Allow begin process Unregisters without Registers

Signed-off-by: Nikita Skrynnik <[email protected]>

* delete one test + fix go leaks

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix test using mutexes

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix more unit tests

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix some tests + fix linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* test StressTest for begin server

Signed-off-by: Nikita Skrynnik <[email protected]>

* delete unneseccary test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix dial chain element to fix test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* minor fix

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* test again

Signed-off-by: Nikita Skrynnik <[email protected]>

* test again

Signed-off-by: Nikita Skrynnik <[email protected]>

* disable one test

Signed-off-by: Nikita Skrynnik <[email protected]>

* add some logs

Signed-off-by: Nikita Skrynnik <[email protected]>

* add more logs

Signed-off-by: Nikita Skrynnik <[email protected]>

* reduce count of events to 10

Signed-off-by: Nikita Skrynnik <[email protected]>

* skip fifo test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix golang linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* apply some review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix review comments related to dial

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix more review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

---------

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Nov 8, 2023
…k@main

PR link: networkservicemesh/sdk#1542

Commit: 20150d6
Author: Nikita Skrynnik
Date: 2023-11-08 16:52:52 +0700
Message:
  - Allow begin to process Unregisters without Registers (#1542)
* Allow begin process Unregisters without Registers

Signed-off-by: Nikita Skrynnik <[email protected]>

* delete one test + fix go leaks

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix test using mutexes

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix more unit tests

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix some tests + fix linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* test StressTest for begin server

Signed-off-by: Nikita Skrynnik <[email protected]>

* delete unneseccary test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix dial chain element to fix test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* minor fix

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* test again

Signed-off-by: Nikita Skrynnik <[email protected]>

* test again

Signed-off-by: Nikita Skrynnik <[email protected]>

* disable one test

Signed-off-by: Nikita Skrynnik <[email protected]>

* add some logs

Signed-off-by: Nikita Skrynnik <[email protected]>

* add more logs

Signed-off-by: Nikita Skrynnik <[email protected]>

* reduce count of events to 10

Signed-off-by: Nikita Skrynnik <[email protected]>

* skip fifo test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix golang linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* apply some review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix review comments related to dial

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix more review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

---------

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Nov 8, 2023
…k@main

PR link: networkservicemesh/sdk#1542

Commit: 20150d6
Author: Nikita Skrynnik
Date: 2023-11-08 16:52:52 +0700
Message:
  - Allow begin to process Unregisters without Registers (#1542)
* Allow begin process Unregisters without Registers

Signed-off-by: Nikita Skrynnik <[email protected]>

* delete one test + fix go leaks

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix test using mutexes

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix more unit tests

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix some tests + fix linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* test StressTest for begin server

Signed-off-by: Nikita Skrynnik <[email protected]>

* delete unneseccary test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix dial chain element to fix test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* minor fix

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* test again

Signed-off-by: Nikita Skrynnik <[email protected]>

* test again

Signed-off-by: Nikita Skrynnik <[email protected]>

* disable one test

Signed-off-by: Nikita Skrynnik <[email protected]>

* add some logs

Signed-off-by: Nikita Skrynnik <[email protected]>

* add more logs

Signed-off-by: Nikita Skrynnik <[email protected]>

* reduce count of events to 10

Signed-off-by: Nikita Skrynnik <[email protected]>

* skip fifo test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix golang linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* apply some review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix review comments related to dial

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix more review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

---------

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Nov 8, 2023
…k@main

PR link: networkservicemesh/sdk#1542

Commit: 20150d6
Author: Nikita Skrynnik
Date: 2023-11-08 16:52:52 +0700
Message:
  - Allow begin to process Unregisters without Registers (#1542)
* Allow begin process Unregisters without Registers

Signed-off-by: Nikita Skrynnik <[email protected]>

* delete one test + fix go leaks

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix test using mutexes

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix more unit tests

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix some tests + fix linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* test StressTest for begin server

Signed-off-by: Nikita Skrynnik <[email protected]>

* delete unneseccary test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix dial chain element to fix test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* minor fix

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* test again

Signed-off-by: Nikita Skrynnik <[email protected]>

* test again

Signed-off-by: Nikita Skrynnik <[email protected]>

* disable one test

Signed-off-by: Nikita Skrynnik <[email protected]>

* add some logs

Signed-off-by: Nikita Skrynnik <[email protected]>

* add more logs

Signed-off-by: Nikita Skrynnik <[email protected]>

* reduce count of events to 10

Signed-off-by: Nikita Skrynnik <[email protected]>

* skip fifo test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix golang linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* apply some review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix review comments related to dial

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix more review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

---------

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Nov 8, 2023
…k@main

PR link: networkservicemesh/sdk#1542

Commit: 20150d6
Author: Nikita Skrynnik
Date: 2023-11-08 16:52:52 +0700
Message:
  - Allow begin to process Unregisters without Registers (#1542)
* Allow begin process Unregisters without Registers

Signed-off-by: Nikita Skrynnik <[email protected]>

* delete one test + fix go leaks

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix test using mutexes

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix more unit tests

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix some tests + fix linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* test StressTest for begin server

Signed-off-by: Nikita Skrynnik <[email protected]>

* delete unneseccary test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix dial chain element to fix test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* minor fix

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* test again

Signed-off-by: Nikita Skrynnik <[email protected]>

* test again

Signed-off-by: Nikita Skrynnik <[email protected]>

* disable one test

Signed-off-by: Nikita Skrynnik <[email protected]>

* add some logs

Signed-off-by: Nikita Skrynnik <[email protected]>

* add more logs

Signed-off-by: Nikita Skrynnik <[email protected]>

* reduce count of events to 10

Signed-off-by: Nikita Skrynnik <[email protected]>

* skip fifo test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix golang linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* apply some review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix review comments related to dial

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix more review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

---------

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Nov 8, 2023
…k@main

PR link: networkservicemesh/sdk#1542

Commit: 20150d6
Author: Nikita Skrynnik
Date: 2023-11-08 16:52:52 +0700
Message:
  - Allow begin to process Unregisters without Registers (#1542)
* Allow begin process Unregisters without Registers

Signed-off-by: Nikita Skrynnik <[email protected]>

* delete one test + fix go leaks

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix test using mutexes

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix more unit tests

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix some tests + fix linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* test StressTest for begin server

Signed-off-by: Nikita Skrynnik <[email protected]>

* delete unneseccary test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix dial chain element to fix test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* minor fix

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* test again

Signed-off-by: Nikita Skrynnik <[email protected]>

* test again

Signed-off-by: Nikita Skrynnik <[email protected]>

* disable one test

Signed-off-by: Nikita Skrynnik <[email protected]>

* add some logs

Signed-off-by: Nikita Skrynnik <[email protected]>

* add more logs

Signed-off-by: Nikita Skrynnik <[email protected]>

* reduce count of events to 10

Signed-off-by: Nikita Skrynnik <[email protected]>

* skip fifo test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix golang linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* apply some review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix review comments related to dial

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix more review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

---------

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Nov 8, 2023
…k@main

PR link: networkservicemesh/sdk#1542

Commit: 20150d6
Author: Nikita Skrynnik
Date: 2023-11-08 16:52:52 +0700
Message:
  - Allow begin to process Unregisters without Registers (#1542)
* Allow begin process Unregisters without Registers

Signed-off-by: Nikita Skrynnik <[email protected]>

* delete one test + fix go leaks

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix test using mutexes

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix more unit tests

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix some tests + fix linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* test StressTest for begin server

Signed-off-by: Nikita Skrynnik <[email protected]>

* delete unneseccary test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix dial chain element to fix test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* minor fix

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* test again

Signed-off-by: Nikita Skrynnik <[email protected]>

* test again

Signed-off-by: Nikita Skrynnik <[email protected]>

* disable one test

Signed-off-by: Nikita Skrynnik <[email protected]>

* add some logs

Signed-off-by: Nikita Skrynnik <[email protected]>

* add more logs

Signed-off-by: Nikita Skrynnik <[email protected]>

* reduce count of events to 10

Signed-off-by: Nikita Skrynnik <[email protected]>

* skip fifo test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix golang linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* apply some review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix review comments related to dial

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix more review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

---------

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Nov 8, 2023
…k@main

PR link: networkservicemesh/sdk#1542

Commit: 20150d6
Author: Nikita Skrynnik
Date: 2023-11-08 16:52:52 +0700
Message:
  - Allow begin to process Unregisters without Registers (#1542)
* Allow begin process Unregisters without Registers

Signed-off-by: Nikita Skrynnik <[email protected]>

* delete one test + fix go leaks

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix test using mutexes

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix more unit tests

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix some tests + fix linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* test StressTest for begin server

Signed-off-by: Nikita Skrynnik <[email protected]>

* delete unneseccary test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix dial chain element to fix test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* minor fix

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* test again

Signed-off-by: Nikita Skrynnik <[email protected]>

* test again

Signed-off-by: Nikita Skrynnik <[email protected]>

* disable one test

Signed-off-by: Nikita Skrynnik <[email protected]>

* add some logs

Signed-off-by: Nikita Skrynnik <[email protected]>

* add more logs

Signed-off-by: Nikita Skrynnik <[email protected]>

* reduce count of events to 10

Signed-off-by: Nikita Skrynnik <[email protected]>

* skip fifo test

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix golang linter issues

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* apply some review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix review comments related to dial

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

* cleanup

Signed-off-by: Nikita Skrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

* fix more review comments

Signed-off-by: Nikita Skrynnik <[email protected]>

---------

Signed-off-by: NSMBot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants