-
Notifications
You must be signed in to change notification settings - Fork 36
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allow begin to process Unregisters without Registers (#1542)
* Allow begin process Unregisters without Registers Signed-off-by: Nikita Skrynnik <[email protected]> * delete one test + fix go leaks Signed-off-by: Nikita Skrynnik <[email protected]> * fix test using mutexes Signed-off-by: Nikita Skrynnik <[email protected]> * fix more unit tests Signed-off-by: Nikita Skrynnik <[email protected]> * fix some tests + fix linter issues Signed-off-by: Nikita Skrynnik <[email protected]> * rerun CI Signed-off-by: Nikita Skrynnik <[email protected]> * test StressTest for begin server Signed-off-by: Nikita Skrynnik <[email protected]> * delete unneseccary test Signed-off-by: Nikita Skrynnik <[email protected]> * fix dial chain element to fix test Signed-off-by: Nikita Skrynnik <[email protected]> * fix linter issues Signed-off-by: Nikita Skrynnik <[email protected]> * cleanup Signed-off-by: Nikita Skrynnik <[email protected]> * minor fix Signed-off-by: Nikita Skrynnik <[email protected]> * rerun CI Signed-off-by: Nikita Skrynnik <[email protected]> * test again Signed-off-by: Nikita Skrynnik <[email protected]> * test again Signed-off-by: Nikita Skrynnik <[email protected]> * disable one test Signed-off-by: Nikita Skrynnik <[email protected]> * add some logs Signed-off-by: Nikita Skrynnik <[email protected]> * add more logs Signed-off-by: Nikita Skrynnik <[email protected]> * reduce count of events to 10 Signed-off-by: Nikita Skrynnik <[email protected]> * skip fifo test Signed-off-by: Nikita Skrynnik <[email protected]> * fix golang linter issues Signed-off-by: Nikita Skrynnik <[email protected]> * rerun CI Signed-off-by: Nikita Skrynnik <[email protected]> * cleanup Signed-off-by: Nikita Skrynnik <[email protected]> * apply some review comments Signed-off-by: Nikita Skrynnik <[email protected]> * cleanup Signed-off-by: Nikita Skrynnik <[email protected]> * fix review comments related to dial Signed-off-by: Nikita Skrynnik <[email protected]> * fix review comments Signed-off-by: Nikita Skrynnik <[email protected]> * cleanup Signed-off-by: Nikita Skrynnik <[email protected]> * rerun CI Signed-off-by: Nikita Skrynnik <[email protected]> * fix more review comments Signed-off-by: Nikita Skrynnik <[email protected]> --------- Signed-off-by: Nikita Skrynnik <[email protected]>
- Loading branch information
1 parent
85ca154
commit 20150d6
Showing
7 changed files
with
414 additions
and
129 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,186 @@ | ||
// Copyright (c) 2023 Cisco and/or its affiliates. | ||
// | ||
// SPDX-License-Identifier: Apache-2.0 | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at: | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package begin_test | ||
|
||
import ( | ||
"context" | ||
"fmt" | ||
"sync" | ||
"testing" | ||
|
||
"github.com/golang/protobuf/ptypes/empty" | ||
"github.com/networkservicemesh/api/pkg/api/registry" | ||
|
||
"github.com/networkservicemesh/sdk/pkg/registry/common/begin" | ||
"github.com/networkservicemesh/sdk/pkg/registry/core/chain" | ||
"github.com/networkservicemesh/sdk/pkg/registry/core/next" | ||
) | ||
|
||
var ( | ||
count = 1000 | ||
) | ||
|
||
type dataRaceServer struct { | ||
count int | ||
} | ||
|
||
func (s *dataRaceServer) Register(ctx context.Context, in *registry.NetworkServiceEndpoint) (*registry.NetworkServiceEndpoint, error) { | ||
s.count++ | ||
return next.NetworkServiceEndpointRegistryServer(ctx).Register(ctx, in) | ||
} | ||
|
||
func (s *dataRaceServer) Find(query *registry.NetworkServiceEndpointQuery, server registry.NetworkServiceEndpointRegistry_FindServer) error { | ||
return next.NetworkServiceEndpointRegistryServer(server.Context()).Find(query, server) | ||
} | ||
|
||
func (s *dataRaceServer) Unregister(ctx context.Context, in *registry.NetworkServiceEndpoint) (*empty.Empty, error) { | ||
s.count-- | ||
return next.NetworkServiceEndpointRegistryServer(ctx).Unregister(ctx, in) | ||
} | ||
|
||
func BenchmarkBegin_RegisterSameIDs(b *testing.B) { | ||
server := chain.NewNetworkServiceEndpointRegistryServer( | ||
begin.NewNetworkServiceEndpointRegistryServer(), | ||
&dataRaceServer{count: 0}, | ||
) | ||
|
||
var wg sync.WaitGroup | ||
wg.Add(count) | ||
b.ResetTimer() | ||
for i := 0; i < count; i++ { | ||
go func() { | ||
_, _ = server.Register(context.Background(), ®istry.NetworkServiceEndpoint{Name: "1"}) | ||
wg.Done() | ||
}() | ||
} | ||
wg.Wait() | ||
} | ||
|
||
func BenchmarkBegin_UnregisterSameIDs(b *testing.B) { | ||
server := chain.NewNetworkServiceEndpointRegistryServer( | ||
begin.NewNetworkServiceEndpointRegistryServer(), | ||
&dataRaceServer{count: 0}, | ||
) | ||
|
||
var wg sync.WaitGroup | ||
wg.Add(count) | ||
b.ResetTimer() | ||
for i := 0; i < count; i++ { | ||
go func() { | ||
_, _ = server.Unregister(context.Background(), ®istry.NetworkServiceEndpoint{Name: "1"}) | ||
wg.Done() | ||
}() | ||
} | ||
wg.Wait() | ||
} | ||
|
||
func BenchmarkBegin_RegisterUnregisterSameIDs(b *testing.B) { | ||
server := chain.NewNetworkServiceEndpointRegistryServer( | ||
begin.NewNetworkServiceEndpointRegistryServer(), | ||
&dataRaceServer{count: 0}, | ||
) | ||
|
||
var wg sync.WaitGroup | ||
wg.Add(2 * count) | ||
b.ResetTimer() | ||
go func() { | ||
for i := 0; i < count; i++ { | ||
go func() { | ||
_, _ = server.Register(context.Background(), ®istry.NetworkServiceEndpoint{Name: "1"}) | ||
wg.Done() | ||
}() | ||
} | ||
}() | ||
|
||
go func() { | ||
for i := 0; i < count; i++ { | ||
go func() { | ||
_, _ = server.Unregister(context.Background(), ®istry.NetworkServiceEndpoint{Name: "1"}) | ||
wg.Done() | ||
}() | ||
} | ||
}() | ||
|
||
wg.Wait() | ||
} | ||
|
||
func BenchmarkBegin_RegisterDifferentIDs(b *testing.B) { | ||
server := chain.NewNetworkServiceEndpointRegistryServer( | ||
begin.NewNetworkServiceEndpointRegistryServer(), | ||
) | ||
|
||
var wg sync.WaitGroup | ||
wg.Add(count) | ||
b.ResetTimer() | ||
for i := 0; i < count; i++ { | ||
local := i | ||
go func() { | ||
_, _ = server.Register(context.Background(), ®istry.NetworkServiceEndpoint{Name: fmt.Sprint(local)}) | ||
wg.Done() | ||
}() | ||
} | ||
wg.Wait() | ||
} | ||
|
||
func BenchmarkBegin_UnregisterDifferentIDs(b *testing.B) { | ||
server := chain.NewNetworkServiceEndpointRegistryServer( | ||
begin.NewNetworkServiceEndpointRegistryServer(), | ||
) | ||
|
||
var wg sync.WaitGroup | ||
wg.Add(count) | ||
b.ResetTimer() | ||
for i := 0; i < count; i++ { | ||
local := i | ||
go func() { | ||
_, _ = server.Unregister(context.Background(), ®istry.NetworkServiceEndpoint{Name: fmt.Sprint(local)}) | ||
wg.Done() | ||
}() | ||
} | ||
wg.Wait() | ||
} | ||
|
||
func BenchmarkBegin_RegisterUnregisterDifferentIDs(b *testing.B) { | ||
server := chain.NewNetworkServiceEndpointRegistryServer( | ||
begin.NewNetworkServiceEndpointRegistryServer(), | ||
) | ||
|
||
var wg sync.WaitGroup | ||
wg.Add(2 * count) | ||
b.ResetTimer() | ||
go func() { | ||
for i := 0; i < count; i++ { | ||
local := i | ||
go func() { | ||
_, _ = server.Register(context.Background(), ®istry.NetworkServiceEndpoint{Name: fmt.Sprint(local)}) | ||
wg.Done() | ||
}() | ||
} | ||
}() | ||
|
||
go func() { | ||
for i := 0; i < count; i++ { | ||
local := i | ||
go func() { | ||
_, _ = server.Unregister(context.Background(), ®istry.NetworkServiceEndpoint{Name: fmt.Sprint(local)}) | ||
wg.Done() | ||
}() | ||
} | ||
}() | ||
|
||
wg.Wait() | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.