Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Skip similar networkservices in netsvcmonitor element #1524

Merged
merged 2 commits into from
Oct 5, 2023
Merged

fix: Skip similar networkservices in netsvcmonitor element #1524

merged 2 commits into from
Oct 5, 2023

Conversation

NikitaSkrynnik
Copy link
Contributor

Description

Currenly, we're not support adanced query parameters networkservicemesh/api#51 and for now Find queries could return similar network services

Issue link

#1521

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@codecov
Copy link

codecov bot commented Oct 5, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@f2a585e). Click here to learn what that means.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1524   +/-   ##
=======================================
  Coverage        ?   66.74%           
=======================================
  Files           ?      259           
  Lines           ?    12338           
  Branches        ?        0           
=======================================
  Hits            ?     8235           
  Misses          ?     3578           
  Partials        ?      525

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NikitaSkrynnik
fix for issue sdk/1521
edbad49 
Signed-off-by: NikitaSkrynnik <[email protected]>
@NikitaSkrynnik
rerun CI
88b0618 
Signed-off-by: Nikita Skrynnik <[email protected]>
denis-tingaikin
denis-tingaikin approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@denis-tingaikin denis-tingaikin merged commit 7ad780b into networkservicemesh:main Oct 5, 2023
17 checks passed
@denis-tingaikin denis-tingaikin mentioned this pull request Oct 5, 2023
Closed
9 tasks
nsmbot pushed a commit to networkservicemesh/cmd-csi-driver that referenced this pull request Oct 5, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c2ef5a9 
…k@main

PR link: networkservicemesh/sdk#1524

Commit: 7ad780b
Author: Nikita Skrynnik
Date: 2023-10-05 21:28:34 +1100
Message:
  - fix: Skip similar networkservices in netsvcmonitor element (#1524)
* fix for issue sdk/1521

Signed-off-by: NikitaSkrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

---------

Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Oct 5, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9a57755 
…k@main

PR link: networkservicemesh/sdk#1524

Commit: 7ad780b
Author: Nikita Skrynnik
Date: 2023-10-05 21:28:34 +1100
Message:
  - fix: Skip similar networkservices in netsvcmonitor element (#1524)
* fix for issue sdk/1521

Signed-off-by: NikitaSkrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

---------

Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Oct 5, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1c77f55 
…k@main

PR link: networkservicemesh/sdk#1524

Commit: 7ad780b
Author: Nikita Skrynnik
Date: 2023-10-05 21:28:34 +1100
Message:
  - fix: Skip similar networkservices in netsvcmonitor element (#1524)
* fix for issue sdk/1521

Signed-off-by: NikitaSkrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

---------

Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Oct 5, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6138dbb 
…k@main

PR link: networkservicemesh/sdk#1524

Commit: 7ad780b
Author: Nikita Skrynnik
Date: 2023-10-05 21:28:34 +1100
Message:
  - fix: Skip similar networkservices in netsvcmonitor element (#1524)
* fix for issue sdk/1521

Signed-off-by: NikitaSkrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

---------

Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Oct 5, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c116dd7 
…k@main

PR link: networkservicemesh/sdk#1524

Commit: 7ad780b
Author: Nikita Skrynnik
Date: 2023-10-05 21:28:34 +1100
Message:
  - fix: Skip similar networkservices in netsvcmonitor element (#1524)
* fix for issue sdk/1521

Signed-off-by: NikitaSkrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

---------

Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
@nsmbot nsmbot mentioned this pull request Oct 5, 2023
Merged
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Oct 5, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
8121b00 
…k@main

PR link: networkservicemesh/sdk#1524

Commit: 7ad780b
Author: Nikita Skrynnik
Date: 2023-10-05 21:28:34 +1100
Message:
  - fix: Skip similar networkservices in netsvcmonitor element (#1524)
* fix for issue sdk/1521

Signed-off-by: NikitaSkrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

---------

Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Oct 5, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
98d8738 
…k@main

PR link: networkservicemesh/sdk#1524

Commit: 7ad780b
Author: Nikita Skrynnik
Date: 2023-10-05 21:28:34 +1100
Message:
  - fix: Skip similar networkservices in netsvcmonitor element (#1524)
* fix for issue sdk/1521

Signed-off-by: NikitaSkrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

---------

Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Oct 5, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
62dbdd5 
…k@main

PR link: networkservicemesh/sdk#1524

Commit: 7ad780b
Author: Nikita Skrynnik
Date: 2023-10-05 21:28:34 +1100
Message:
  - fix: Skip similar networkservices in netsvcmonitor element (#1524)
* fix for issue sdk/1521

Signed-off-by: NikitaSkrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

---------

Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Oct 5, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2b1cdf3 
…k@main

PR link: networkservicemesh/sdk#1524

Commit: 7ad780b
Author: Nikita Skrynnik
Date: 2023-10-05 21:28:34 +1100
Message:
  - fix: Skip similar networkservices in netsvcmonitor element (#1524)
* fix for issue sdk/1521

Signed-off-by: NikitaSkrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

---------

Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Oct 5, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c585f1c 
…k@main

PR link: networkservicemesh/sdk#1524

Commit: 7ad780b
Author: Nikita Skrynnik
Date: 2023-10-05 21:28:34 +1100
Message:
  - fix: Skip similar networkservices in netsvcmonitor element (#1524)
* fix for issue sdk/1521

Signed-off-by: NikitaSkrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

---------

Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
@nsmbot nsmbot mentioned this pull request Oct 5, 2023
Merged
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Oct 5, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
223b90f 
…k@main

PR link: networkservicemesh/sdk#1524

Commit: 7ad780b
Author: Nikita Skrynnik
Date: 2023-10-05 21:28:34 +1100
Message:
  - fix: Skip similar networkservices in netsvcmonitor element (#1524)
* fix for issue sdk/1521

Signed-off-by: NikitaSkrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

---------

Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
@nsmbot nsmbot mentioned this pull request Oct 5, 2023
Merged
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Oct 5, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
dae1450 
…k@main

PR link: networkservicemesh/sdk#1524

Commit: 7ad780b
Author: Nikita Skrynnik
Date: 2023-10-05 21:28:34 +1100
Message:
  - fix: Skip similar networkservices in netsvcmonitor element (#1524)
* fix for issue sdk/1521

Signed-off-by: NikitaSkrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

---------

Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Oct 5, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
49539c6 
…k@main

PR link: networkservicemesh/sdk#1524

Commit: 7ad780b
Author: Nikita Skrynnik
Date: 2023-10-05 21:28:34 +1100
Message:
  - fix: Skip similar networkservices in netsvcmonitor element (#1524)
* fix for issue sdk/1521

Signed-off-by: NikitaSkrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

---------

Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
This was referenced Oct 5, 2023
Merged
Merged
Merged
Merged
Merged
Merged
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Oct 5, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
382a8a1 
…k@main

PR link: networkservicemesh/sdk#1524

Commit: 7ad780b
Author: Nikita Skrynnik
Date: 2023-10-05 21:28:34 +1100
Message:
  - fix: Skip similar networkservices in netsvcmonitor element (#1524)
* fix for issue sdk/1521

Signed-off-by: NikitaSkrynnik <[email protected]>

* rerun CI

Signed-off-by: Nikita Skrynnik <[email protected]>

---------

Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
This was referenced Oct 5, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NikitaSkrynnik @denis-tingaikin