fix: Skip similar networkservices in netsvcmonitor element #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: denis-tingaikin <[email protected]>
denis-tingaikin
force-pushed
the
fix-issue-1521
branch
from
c24b2e4
to
f284fb0
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1523 +/- ##
=======================================
Coverage ? 66.67%
=======================================
Files ? 259
Lines ? 12338
Branches ? 0
=======================================
Hits ? 8226
Misses ? 3586
Partials ? 526 ☔ View full report in Codecov by Sentry. |
Signed-off-by: denis-tingaikin <[email protected]>
denis-tingaikin
requested review from
edwarnicke,
LionelJouin and
NikitaSkrynnik
LionelJouin
approved these changes
Oct 4, 2023
|
workarounded and merged via #1524 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currenly, we're not support adanced query parameters networkservicemesh/api#51 and for now Find queries could return similar network services
Issue link
#1521
How Has This Been Tested?
Types of changes