Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update from update/networkservicemesh/sdk #538

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Update from update/networkservicemesh/sdk #538

merged 1 commit into from
Sep 14, 2022

Commits on Sep 14, 2022

  1. Update go.mod and go.sum to latest version from networkservicemesh/sd… 

    …k@main

PR link: networkservicemesh/sdk#1353

Commit: 97e00ec
Author: toby cabot
Date: 2022-09-14 19:33:40 -0400
Message:
  - Don't trace gRPC "Canceled" errors (#1353)
We were getting a *lot* of log chaff at TRACE level during normal
operation because gRPC returns a "context canceled" error periodically
but it's not really an error for us because we immediately loop around
again.

This commit uses the gRPC status.Code() method to identify these
non-errors. It also uses errors.Is() instead of == to compare error
objects. This handles wrapped errors.

https://pkg.go.dev/google.golang.org/grpc/status#Code

https://github.com/golang/go/wiki/ErrorValueFAQ#how-should-i-change-my-error-handling-code-to-work-with-the-new-features

Signed-off-by: Toby Cabot <[email protected]>

Signed-off-by: Toby Cabot <[email protected]>
Signed-off-by: NSMBot <[email protected]>
    NSMBot committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    c566ad1 View commit details
    Browse the repository at this point in the history