Update from update/networkservicemesh/sdk #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k@main PR link: networkservicemesh/sdk#1353 Commit: 97e00ec Author: toby cabot Date: 2022-09-14 19:33:40 -0400 Message: - Don't trace gRPC "Canceled" errors (#1353) We were getting a *lot* of log chaff at TRACE level during normal operation because gRPC returns a "context canceled" error periodically but it's not really an error for us because we immediately loop around again. This commit uses the gRPC status.Code() method to identify these non-errors. It also uses errors.Is() instead of == to compare error objects. This handles wrapped errors. https://pkg.go.dev/google.golang.org/grpc/status#Code https://github.com/golang/go/wiki/ErrorValueFAQ#how-should-i-change-my-error-handling-code-to-work-with-the-new-features Signed-off-by: Toby Cabot <[email protected]> Signed-off-by: Toby Cabot <[email protected]> Signed-off-by: NSMBot <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Sep 14, 2022
…d-nsmgr@main PR link: networkservicemesh/cmd-nsmgr#538 Commit: 2598f96 Author: Network Service Mesh Bot Date: 2022-09-14 18:39:17 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sd… Signed-off-by: NSMBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update go.mod and go.sum to latest version from networkservicemesh/sdk@main
PR link: networkservicemesh/sdk#1353
Commit: 97e00ec
Author: toby cabot
Date: 2022-09-14 19:33:40 -0400
Message:
We were getting a lot of log chaff at TRACE level during normal
operation because gRPC returns a "context canceled" error periodically
but it's not really an error for us because we immediately loop around
again.
This commit uses the gRPC status.Code() method to identify these
non-errors. It also uses errors.Is() instead of == to compare error
objects. This handles wrapped errors.
https://pkg.go.dev/google.golang.org/grpc/status# Code
https://github.com/golang/go/wiki/ErrorValueFAQ# how-should-i-change-my-error-handling-code-to-work-with-the-new-features
Signed-off-by: Toby Cabot [email protected]
Signed-off-by: Toby Cabot [email protected]