remove duplicate placeholder in sample config#1397
remove duplicate placeholder in sample config#1397jpinsonneau merged 1 commit intonetobserv:mainfrom
Conversation
📝 WalkthroughWalkthroughA duplicate placeholder configuration line was removed from the sample YAML config file, leaving a single placeholder value for the DNS flag response code filter. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
jotak
left a comment
There was a problem hiding this comment.
LGTM
But I just ran the provided script to update this config, so is it that it's also wrong on the operator side?
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ok also created netobserv/netobserv-operator#2616 |
Description
Fix sample
Dependencies
n/a
Checklist
Summary by CodeRabbit