Skip to content

remove duplicate placeholder in console plugin config#2616

Merged
openshift-merge-bot[bot] merged 1 commit intonetobserv:mainfrom
jpinsonneau:config-fix
Apr 2, 2026
Merged

remove duplicate placeholder in console plugin config#2616
openshift-merge-bot[bot] merged 1 commit intonetobserv:mainfrom
jpinsonneau:config-fix

Conversation

@jpinsonneau
Copy link
Copy Markdown
Member

@jpinsonneau jpinsonneau commented Apr 2, 2026

Description

Fix console plugin config

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labeled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Summary by CodeRabbit

  • Chores
    • Removed duplicate configuration entry in DNS response code filter settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 761ad48f-d69a-4435-afc1-1a8cce171d39

📥 Commits

Reviewing files that changed from the base of the PR and between 08ca9d4 and bb00b66.

📒 Files selected for processing (1)
  • internal/controller/consoleplugin/config/static-frontend-config.yaml
💤 Files with no reviewable changes (1)
  • internal/controller/consoleplugin/config/static-frontend-config.yaml

📝 Walkthrough

Walkthrough

Removed a duplicate placeholder field entry in the dns_flag_response_code filter configuration within the static frontend config YAML file. One redundant line deleted; configuration structure unchanged.

Changes

Cohort / File(s) Summary
Configuration Cleanup
internal/controller/consoleplugin/config/static-frontend-config.yaml
Removed duplicate placeholder key from the dns_flag_response_code filter definition, preserving the single canonical placeholder text for the filter.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is incomplete. While it mentions the fix, it lacks detail and doesn't fully address the template requirements like environment setup and testing information. Expand description with specifics about the duplicate field removed and why it was problematic. Clarify testing approach given the trivial nature of the change.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing a duplicate placeholder field in the console plugin config YAML.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@jpinsonneau jpinsonneau added lgtm approved no-qe This PR doesn't necessitate QE approval labels Apr 2, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 4045d1b into netobserv:main Apr 2, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm no-qe This PR doesn't necessitate QE approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant