Upgrade to pop/v5 #273
Merged
Upgrade to pop/v5 #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschlarman
added
the
type: chore
kschlarman
force-pushed
the
upgrade-to-pop-v5
branch
from
4640e70 to
b25694d
Compare
|
@vbrown608 Had to rebase if you could give this another 🐧 . Ran through the manual tests again on staging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
pop/v5 will be needed if we wish to have support tracing for DB requests. See gobuffalo/pop#599.
I took a look through the changelog, and this was the only change that I found to have an impact.
- Test plan
This has been tested on staging:
- Description for the changelog
Upgrade github.com/gobuffalo/pop
- A picture of a cute animal (not mandatory but encouraged)
