Support SQL instrumentation with Open Census, Open Tracing, AWS Xray, Google Stack Driver #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
force-pushed
the
add-instr-sql-driver
branch
from
af7d9dc to
5f40054
Compare
aeneasr
force-pushed
the
add-instr-sql-driver
branch
from
5f40054 to
22480bd
Compare
stanislas-m
approved these changes
Oct 13, 2020
|
@stanislas-m I'm looking into some weird behavior with pgx in combination with instrumentation - please stay tuned before merging :) |
Adds options ``` // UseInstrumentedDriver if set to true uses a wrapper for the underlying driver which exposes tracing // information in the Open Tracing, Open Census, Google, and AWS Xray format. This is useful when using // tracing with Jaeger, DataDog, Zipkin, or other tracing software. UseInstrumentedDriver bool // InstrumentedDriverOptions sets the options for the instrumented driver. These options are empty by default meaning // that instrumentation is disabled. // // For more information check out the docs at https://github.com/luna-duclos/instrumentedsql. If you use Open Tracing, these options // could looks as follows: // // InstrumentedDriverOptions: []instrumentedsql.Opt{instrumentedsql.WithTracer(opentracing.NewTracer(true))} // // It is also recommended to include `instrumentedsql.WithOmitArgs()` which prevents SQL arguments (e.g. passwords) // from being traced or logged. InstrumentedDriverOptions []instrumentedsql.Opt ``` to `pop.ConnectionDetails`, allowing to instrument SQL queries using Open Tracing, Open Census, AWS XRay or Google Stack Driver. Signed-off-by: aeneasr <[email protected]>
aeneasr
force-pushed
the
add-instr-sql-driver
branch
from
22480bd to
5671314
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds options
to
pop.ConnectionDetails, allowing to instrument SQL queries using Open Tracing, Open Census, AWS XRay or Google Stack Driver.