Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update nanoid dependency version #6982

Merged

Conversation

DerianCordobaPerez
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes #6972

Currently, the CLI project is using a nanoid version (v3.3.7) causing issues when running the npm install, npm ci, or npm audit fix command showing the following error:

nanoid  <3.3.8
Severity: moderate
Predictable results in nanoid generation when given non-integer values - https://github.com/advisories/GHSA-mwcw-c2x4-8c55
fix available via `npm audit fix`
node_modules/netlify-cli/node_modules/nanoid

1 moderate severity vulnerability

To address all issues, run:
  npm audit fix

Vulnerability is: Predictable results in nanoid generation when given non-integer values

image ---

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

image

@sarahetter sarahetter changed the title Update nanoid dependency version fix: Update nanoid dependency version Dec 31, 2024
@sarahetter sarahetter changed the title fix: Update nanoid dependency version fix: update nanoid dependency version Dec 31, 2024
@sarahetter sarahetter enabled auto-merge (squash) January 6, 2025 21:12
@sarahetter sarahetter merged commit 30c94b4 into netlify:main Jan 6, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependencies so nanoid can be updated to 3.3.8
2 participants