-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci-tests): split tests across multiple machines #4212
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
7c024f1
chore: load balance tests across machines
erezrokah 9a6801a
chore: fix typo
erezrokah 924feeb
chore: remove top level await so it works on Node.js 12
erezrokah 6b000e8
chore: use less machines
erezrokah 455e49c
test: improve balancing algorithm
erezrokah b5ccdde
chore(ci): remove redundant matrix values
erezrokah 10ed526
chore: handle windows paths
erezrokah 9fa1d4b
chore: cleanup code
erezrokah 7b2b18a
chore: update docs
erezrokah af3403b
chore: revert lts change
erezrokah d226007
chore: update setup-node
erezrokah 6708187
test: limit concurrency in CI
erezrokah bff2bf8
chore: increase machines to 4
erezrokah e71b173
chore: use official AVA release
erezrokah c760638
Merge branch 'main' into chore/load_balance_tests
erezrokah 630405c
chore(ci): use actions/checkout@v3
erezrokah 88f2ac4
Merge branch 'main' into chore/load_balance_tests
erezrokah 91435c4
Merge branch 'main' into chore/load_balance_tests
erezrokah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
import fs from 'fs' | ||
import path from 'path' | ||
import process from 'process' | ||
|
||
// eslint-disable-next-line node/no-unpublished-import | ||
import { isCI } from 'ci-info' | ||
|
||
// `tests-metadata.json` is created by running `npm run test:measure` | ||
// eslint-disable-next-line node/no-sync | ||
const testData = JSON.parse(fs.readFileSync('tests-metadata.json')) | ||
|
||
const getOrder = (file) => { | ||
const fileRelative = path.relative(process.cwd(), file).replace(/\\/g, '/') | ||
if (testData[fileRelative]) { | ||
return testData[fileRelative].order | ||
} | ||
|
||
console.warn(`Missing test metadata for ${fileRelative}`) | ||
return Number.MAX_SAFE_INTEGER | ||
} | ||
|
||
const sortTestFiles = (file1, file2) => getOrder(file1) - getOrder(file2) | ||
|
||
const config = { | ||
files: ['packages/**/tests/*.{cjs,mjs,js}', 'packages/**/tests/**/tests.{cjs,mjs,js}'], | ||
verbose: true, | ||
timeout: '120s', | ||
workerThreads: false, | ||
environmentVariables: { | ||
FORCE_COLOR: '1', | ||
}, | ||
// we only sort in CI to split efficiently across machines | ||
...(isCI && { sortTestFiles }), | ||
} | ||
|
||
export default config |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering whether YAML aliases could be used to avoid the repetitions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actions/runner#1182 π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too bad :(
Let's keep the repetition then π