-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci-tests): split tests across multiple machines #4212
Conversation
The speed benefit is really good: 18 minutes to 9 minutes! 🎉 |
Looks like some tests are failing randomly, so I'll need to figure it out. Also, once the PR is ready we'll need to update branch protection rules to match the new status checks names |
52777c6
to
2f5ff2a
Compare
@@ -20,7 +20,8 @@ | |||
"test:dev": "run-s test:dev:*", | |||
"test:ci": "run-s test:ci:*", | |||
"test:dev:ava": "ava", | |||
"test:ci:ava": "c8 -r lcovonly -r text -r json ava", | |||
"test:measure": "node tools/tests_duration.mjs", | |||
"test:ci:ava": "c8 -r lcovonly -r text -r json ava --concurrency 1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used concurrency
as I was getting out of memory errors in CI.
AVA itself runs using serial
in their CI, so we should consider doing the same, see https://github.com/avajs/ava/blob/ada1a4f8876ad7b2476440609691e301a02f3951/test/snapshot-workflow/README.md#serial-execution
concurrency
- number of parallel processes to spawn (a process is spawned per test file)serial
- number of parallel tests within the same file
bc77fa6
to
e71b173
Compare
This PR is ready. We'll need to update the branch protection rules to be able to merge it. |
Co-authored-by: ehmicky <[email protected]>
machine: '0' | ||
- os: ubuntu-latest | ||
node-version: '*' | ||
install-command: npm install --no-package-lock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering whether YAML aliases could be used to avoid the repetitions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too bad :(
Let's keep the repetition then 👍
🎉 Thanks for submitting a pull request! 🎉
Summary
Redo of #4139 with better load balancing
Todo
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)