Skip to content

Fix deterministic CI failures across active pull requests - #1991

Merged
Aaronontheweb merged 1 commit into
netclaw-dev:devfrom
Aaronontheweb:fix/deterministic-racy-tests
Aug 18, 2026
Merged

Fix deterministic CI failures across active pull requests#1991
Aaronontheweb merged 1 commit into
netclaw-dev:devfrom
Aaronontheweb:fix/deterministic-racy-tests

Conversation

@Aaronontheweb

@Aaronontheweb Aaronontheweb commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

This PR fixes deterministic and race-prone failures found across #1988, #1987, and #1981.

  • The PID watchdog now uses TimeProvider and a completion signal.
  • The SignalR client tests now use TestServer without loopback ports.
  • The MCP stdio tests now use the repository smoke server without npm.
  • The PowerShell retry tests now wait for virtual timer creation.
  • The PowerShell elapsed result now uses the injected clock.
  • The skill order test no longer asserts an unrelated skill version.
  • Dependabot now ignores the incompatible Roslyn 5.9.0 update.

PR #1989 now owns its seed-batch fix. This PR does not duplicate that change.

The Roslyn 5.9.0 package requires an unavailable analyzer build. Its generator also conflicts with the current SDK compiler.

Validation

  • dotnet restore Netclaw.slnx
  • dotnet build Netclaw.slnx -c Release --no-restore
  • Full suite: 7,550 passed, 15 skipped, and 0 failed.
  • SignalR group: five repeated passes.
  • PID watchdog group: ten repeated passes.
  • PowerShell probe group: ten repeated passes.
  • MCP stdio group: two repeated passes.
  • dotnet slopwatch analyze
  • pwsh ./scripts/Add-FileHeaders.ps1 -Verify
  • Changed C# files passed the focused whitespace check.

@Aaronontheweb
Aaronontheweb force-pushed the fix/deterministic-racy-tests branch from 9d0e9b1 to 82dbbee Compare August 18, 2026 17:52
@Aaronontheweb Aaronontheweb added tests All issues related to testing, quality assurance, and smoke testing. bug Something isn't working labels Aug 18, 2026
@Aaronontheweb
Aaronontheweb enabled auto-merge (squash) August 18, 2026 18:10
@Aaronontheweb
Aaronontheweb disabled auto-merge August 18, 2026 19:18
@Aaronontheweb
Aaronontheweb merged commit 70fa5ea into netclaw-dev:dev Aug 18, 2026
16 of 17 checks passed
@Aaronontheweb
Aaronontheweb deleted the fix/deterministic-racy-tests branch August 18, 2026 19:18
@Aaronontheweb Aaronontheweb mentioned this pull request Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working tests All issues related to testing, quality assurance, and smoke testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant