fix(mcp): bound stdio probe handshake by the probe timeout - #1988
Closed
Aaronontheweb wants to merge 1 commit into
Closed
fix(mcp): bound stdio probe handshake by the probe timeout#1988Aaronontheweb wants to merge 1 commit into
Aaronontheweb wants to merge 1 commit into
Conversation
The MCP doctor's offline probe launched a real stdio subprocess but only bounded ListToolsAsync with the 15s probe token. The connect handshake was left to the SDK's 60s default InitializationTimeout, so on slow/cold runners (e.g. npx cold start) the handshake blew past it and threw an uncaught TimeoutException, crashing the probe and flaking CI (Test-macos-26). Thread the probe budget into McpClientOptions.InitializationTimeout and map a timed-out handshake to Unreachable so an unreachable stdio server is reported deterministically instead of escaping as a crash.
Aaronontheweb
added
bug
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MCP doctor's offline probe launched a real stdio subprocess but only bounded ListToolsAsync with the 15s probe token. The connect handshake was left to the SDK's 60s default InitializationTimeout, so on slow/cold runners (e.g. npx cold start) the handshake blew past it and threw an uncaught TimeoutException that crashed the probe and flaked CI (Test-macos-26).
Changes
Verified locally: previously-failing test now passes in ~1s (was failing at ~70s); full McpServersDoctorCheckTests suite 10/10 green; Release build 0 warnings / 0 errors.