Skip to content

test(mcp): surface stdio connect diagnostics in prompt smoke test - #1950

Merged
Aaronontheweb merged 2 commits into
devfrom
fix/mcp-prompt-stdio
Aug 14, 2026
Merged

test(mcp): surface stdio connect diagnostics in prompt smoke test#1950
Aaronontheweb merged 2 commits into
devfrom
fix/mcp-prompt-stdio

Conversation

@Aaronontheweb

Copy link
Copy Markdown
Collaborator

Fixes the opaque Windows failure of SmokeMcpPromptSkillTests.ManagerDiscoversAndLoadsPromptOverStdio(serverKind: \"python\").

Problem

On Windows CI (run 31794198529), the python theory case fails after 1m10s with Assert.IsType() Failure: Value is null at line 37. The manager swallows the MCP SDK TimeoutException (60s InitializationTimeout default) into an Unreachable status, and this test never calls AssertConnected nor passes an ITestOutputHelper — so CI shows only an opaque null and the real startup error goes to NullLogger.

Prior context

Fix

Diagnostics-first, per the #1904 pattern — no timeout jiggling:

  • Inject ITestOutputHelper into the test.
  • Call harness.AssertConnected(\"smoke\") before the skill lookup, so the next Windows failure names the manager's real exception instead of an opaque null.

This is the prerequisite for a causal fix (expected: python stdio child exceeds the 60s init budget on Windows). If the retained error confirms a timeout, the follow-up is to raise the stdio InitializationTimeout in McpClientManager.BuildClientOptions.

@Aaronontheweb Aaronontheweb added tests All issues related to testing, quality assurance, and smoke testing. mcp Model context protocol server / client issues. platform:windows Windows-specific issues and support observability labels Aug 14, 2026
@Aaronontheweb

Copy link
Copy Markdown
Collaborator Author

This is just a test observability fix, no actual behavioral or test changes yet.

@Aaronontheweb
Aaronontheweb merged commit 0c363b6 into dev Aug 14, 2026
22 of 23 checks passed
@Aaronontheweb
Aaronontheweb deleted the fix/mcp-prompt-stdio branch August 14, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mcp Model context protocol server / client issues. observability platform:windows Windows-specific issues and support tests All issues related to testing, quality assurance, and smoke testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant