test(mcp): preserve startup failure diagnostics - #1904
Merged
Conversation
Aaronontheweb
enabled auto-merge (squash)
August 12, 2026 14:43
Aaronontheweb
force-pushed
the
fix/mcp-notification-startup-flake
branch
from
August 12, 2026 15:20
038ac8b to
c143f99
Compare
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence and scope
Windows run
31560045253, job94000330013, failed afterStartAsyncbecause the test read a nullNotificationLease. The test used a null logger and did not call the existingAssertConnectedhelper, so the run discarded the startup exception that would identify the production cause.This change does not alter MCP runtime behavior, timeout values, retries, or lease assertions. It makes any connection failure fail first with the server state and status message. It also retains the manager's full exception in test output. The negative test proves that a missing stdio process reports
UnreachableandFailed to reach MCP server, and that its command and transport exception reach the output, before the lease assertion.This PR does not prove or fix an underlying production MCP startup defect. If the intermittent Windows startup failure remains, the next run will retain the exception needed for a causal follow-up.
Verification
Netclaw.Daemon.TestsRelease suite: 1,019 passed, repeated 3 timesdotnet build Netclaw.slnx -c Release --no-restore: passed with 0 warnings and 0 errorsdotnet format --verify-no-changes: passedpwsh ./scripts/Add-FileHeaders.ps1 -Verify: passedThe repo-wide Slopwatch scan still reports one pre-existing warning in
PowerShellHostProbeTests.cs; this change does not touch that file.