Skip to content

Fix the legacy reminder alert test race #1906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aaronontheweb merged 1 commit into from
Aug 12, 2026
Merged

Fix the legacy reminder alert test race #1906

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 7 additions & 23 deletions src/Netclaw.Actors.Tests/Reminders/ReminderManagerActorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
using Netclaw.Actors.Reminders;
using Netclaw.Actors.Tests.Hosting;
using Netclaw.Configuration;
using Netclaw.Tests.Utilities;
using Xunit;
using static Netclaw.Actors.Sessions.SessionProtocol;
using static Netclaw.Actors.Reminders.ReminderProtocol;
Expand Down Expand Up @@ -550,9 +551,10 @@ public async Task Save_allows_narrower_boundary_than_requested_audience()
[Fact]
public async Task Startup_emits_alert_for_legacy_reminder_missing_trust_fields()
{
using var directory = new DisposableTempDir();
const string reminderId = "legacy-reminder-alert";
var now = TimeProvider.System.GetUtcNow();
var paths = new NetclawPaths(_basePath);
var paths = new NetclawPaths(directory.Path);
paths.EnsureDirectoriesExist();
var filePath = Path.Combine(paths.RemindersDirectory, $"{Uri.EscapeDataString(reminderId)}.json");
File.WriteAllText(filePath, $$"""
Expand All @@ -574,7 +576,7 @@ public async Task Startup_emits_alert_for_legacy_reminder_missing_trust_fields()
var pipeline = new SessionPipeline(
Sys,
new RequiredActor<SessionManagerActorKey>(ActorRegistry.For(Sys)),
new NetclawPaths(Path.Combine(Path.GetTempPath(), $"netclaw-test-{Guid.NewGuid():N}")));
paths);
var defaults = new EffectivePolicyDefaults(
DeploymentPosture.Team, TrustAudience.Team, ShellExecutionMode.Off, false);

Expand All @@ -590,32 +592,14 @@ public async Task Startup_emits_alert_for_legacy_reminder_missing_trust_fields()
NullReminderChannelNotifier.Instance)),
"legacy-reminder-alert-manager");

// The legacy-schema alert is emitted synchronously inside PreStart, and
// an actor processes mailbox messages only AFTER PreStart completes — so
// a successful health reply is a deterministic signal that PreStart (and
// the emit) has run. Awaiting that signal replaces a wall-clock
// AwaitAssertAsync(5s) poll that flaked under heavy parallel CI load: when
// the shared ThreadPool is saturated, PreStart can be scheduled later than
// a fixed 5s budget, leaving the sink empty when the poll gives up. The
// generous Ask timeout absorbs that scheduling latency without polling —
// it returns as soon as the actor is ready.
await manager.Ask<ReminderHealthResponse>(
GetReminderHealthQuery.Instance,
TimeSpan.FromSeconds(30),
TestContext.Current.CancellationToken);

// Keep the Ask as the startup barrier (it absorbs dispatcher
// scheduling latency under parallel CI load), but poll the sink
// instead of trusting a one-shot post-Ask read: the health reply
// proves PreStart completed, not that the alert reached the sink.
// This test has flaked on CI twice (#1405, #1844) with an empty
// sink immediately after a successful Ask reply.
await AwaitAssertAsync(() =>
{
Assert.Contains(sink.Alerts, alert =>
alert.Category == AlertType.ReminderSchemaDropped
&& alert.Summary.Contains(reminderId, StringComparison.Ordinal));
}, duration: TimeSpan.FromSeconds(30), cancellationToken: TestContext.Current.CancellationToken);
Assert.Contains(sink.Alerts, alert =>
alert.Category == AlertType.ReminderSchemaDropped
&& alert.Summary.Contains(reminderId, StringComparison.Ordinal));
}

/// <summary>
Expand Down
Loading