Skip to content

Fix the legacy reminder alert test race - #1906

Merged
Aaronontheweb merged 1 commit into
netclaw-dev:devfrom
Aaronontheweb:fix/reminder-legacy-alert-test-race
Aug 12, 2026
Merged

Fix the legacy reminder alert test race#1906
Aaronontheweb merged 1 commit into
netclaw-dev:devfrom
Aaronontheweb:fix/reminder-legacy-alert-test-race

Conversation

@Aaronontheweb

Copy link
Copy Markdown
Collaborator

Cause

The fixture manager and the test store shared one reminder directory.

File.WriteAllText exposed a partial JSON file to the fixture store. The fixture store could classify and delete that file as invalid.

The actor under test then had no legacy rejection to report.

Fix

  • Give the test a private temporary directory.
  • Construct one store after the fixture write completes.
  • Keep the actor health response as the startup barrier.
  • Remove the redundant sink poll and obsolete comments.

Proof

  • The focused test passed 20 consecutive runs.
  • All 39 ReminderManagerActorTests passed.
  • The file header check passed.
  • Slopwatch found no new issue. It reported one existing SW004 warning in PowerShellHostProbeTests.cs.

This pull request does not change production code.

@Aaronontheweb Aaronontheweb left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb
Aaronontheweb merged commit 11da3d8 into netclaw-dev:dev Aug 12, 2026
17 checks passed
@Aaronontheweb
Aaronontheweb deleted the fix/reminder-legacy-alert-test-race branch August 12, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant