Fixes #20755: Scope ProviderFilterSet.search() to Provider Fields
#20763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop traversing the related ProviderAccount in ProviderFilterSet.search(). Including related models in NetBox search() can yield duplicate results and unexpected matches, and also triggers unnecessary joins. Fixes netbox-community#20755
jeremystretch
requested review from
a team and
jnovinger
and removed request for
a team
jnovinger
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20755
Stop traversing the related
ProviderAccountinProviderFilterSet.search().Including related models in NetBox
search()methods can cause duplicate results, unexpected matches, and unnecessary joins.