Duplicate Responses in filterqueries

[MrFoxTrot]

NetBox Edition

NetBox Community

NetBox Version

v4.4.5

Python Version

3.12

Steps to Reproduce

1. Create Circuits ->Provider
2. Create 2+ Circuits -> Provider Accounts assigned at Circuits ->Provider from first step
3. Go to Circuits ->Provider and filter by created provider name

Expected Behavior

Query returns 1 object

Observed Behavior

Query returns 2+ objects with same id

[bctiemann]

I'd be interested to know whether this behavior occurs in any similar search results, i.e. anything with a "count" column in this kind of relationship. I'm going to open this as "needs owner", but @MrFoxTrot if you are able could you please do a quick check for other similar areas where this might be occurring?

[pheus]

Thanks for the report! I dug into this and it doesn’t look like a common issue. The root cause is that ProviderFilterSet.search() is querying fields on the related ProviderAccount model in addition to the provider’s own name, description, and comments:

netbox/netbox/circuits/filtersets.py

Lines 92 to 93 in 730d730

	Q(accounts__account__icontains=value) |
	Q(accounts__name__icontains=value) |

In NetBox, search() methods shouldn’t traverse related models.

I recommend removing the ProviderAccount lookups so the search is limited to the provider fields. If that sounds good, I’m happy to open a PR to address it.

[bctiemann]

@pheus That sounds right to me. Thanks!