Closes #20527: Address deprecation warnings #20533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the accessor for the `u_height` column from `device_type.u_height` to `device_type__u_height` for data retrieval in device tables (django-tables2 deprecation).
Update EmptyGroupByJSONBAgg('data', order_by=['weight', 'name']) to
follow Django 5.2 deprecation of the ordering kwarg on PostgreSQL
aggregates.
Consolidates the import for `ObjectChangeType` under `core.graphql.types`. Ensures consistency in type hinting and prevents potential import errors.
Replaces generic `info` parameters with explicitly typed `info: Info` across multiple GraphQL mixins. Ensures better type safety and consistency with Strawberry's typing standards. This removes the "argument name‑based matching of 'info' is deprecated" warning and future‑proofs for Strawberry 1.0.
Replaces `prefix: str` with `prefix: DirectiveValue[str]` in GraphQL filter methods. Ensures compatibility with Strawberry's directive typing and improves type safety.
Adopt Django 6.0’s future default by adding `assume_scheme='https'` to `ContactImportForm.link` and `ContactForm.link`. This silences the URLField deprecation raised at import time when constructing form fields from model URLFields.
pheus
commented
Oct 8, 2025
jeremystretch
requested review from
a team and
jnovinger
and removed request for
a team
jnovinger
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20527
This PR removes the warnings reported in #20527 by updating form fields, GraphQL resolvers, table accessors, and PostgreSQL aggregates to their current, forward‑compatible APIs. It also consolidates a GraphQL import path for clarity.
None of the changes alter user‑visible behavior; they silence deprecations and improve typing so we’re ready for Django 6.0, Strawberry ≥1.0, and django‑tables2 v3.
What’s changed
Forms (URLField default scheme)
assume_scheme='https'to:ContactImportForm.linkContactForm.linkassume_scheme='https'silencesRemovedInDjango60Warningduring form construction.GraphQL (Strawberry)
infoparameters withinfo: Infoacross GraphQL mixins and types to remove theprefixdirective, annotate asprefix: DirectiveValue[str]for correctness.ObjectChangeTypeundercore.graphql.typesto keep type hints consistent.Tables (django-tables2)
DeviceTableto usedevice_type__u_heightinstead ofdevice_type.u_heightto comply withdjango_tables2’s__accessor convention and remove the deprecation.Querysets (PostgreSQL aggregates)
ordering=withorder_by=onEmptyGroupByJSONBAgg(...)to match Django 5.2+.