Fixes #20252: Remove generic AddObject from ObjectChildrenView #20279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Registering the generic AddObject action on ObjectChildrenView results in duplicate "Add" buttons alongside the context‑specific add action (e.g., "Add Prefix"). The generic action also fails to pre-populate the parent context. Remove the generic registration so child lists show only the contextual add action provided by core views and plugins. Fixes netbox-community#20252
jnovinger
requested review from
a team and
jnovinger
and removed request for
a team
jnovinger
approved these changes
Sep 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20252
Summary
Remove the generic
AddObjectaction fromObjectChildrenView.This prevents duplicate “Add” buttons on child object list views and keeps only the contextual add action (e.g., Add Prefix).
No API/DB changes; plugins that already register a contextual add action are unaffected.