Duplicate “Add” buttons on child object list views

[pheus]

Deployment Type

Self-hosted

NetBox Version

v4.4.0

Python Version

3.10

Steps to Reproduce

Minimal example (Prefixes → Child Prefixes):

1. Create a parent prefix (e.g., 10.0.0.0/8).
2. Open the parent prefix’s detail view.
3. Navigate to the Child Prefixes view for that prefix.
4. Observe two buttons at the top right: a contextual Add Prefix button and a generic Add button.

Also reproducible on other child views (examples):

• Prefixes → Child Ranges
• Racks → Non-racked Devices
• Device → Contacts

Expected Behavior

Only one add action should be presented: the contextual add button for the specific child view (e.g., Add Prefix on Child Prefixes).

Observed Behavior

Both a contextual add button (e.g., Add Prefix) and a generic Add button are displayed. The generic Add button opens the create form without pre-populating the parent context.

[pheus]

Thanks for the work on ObjectActions in #19774 !

While reviewing the duplicate “Add” buttons reported above, it appears that ObjectChildrenView now registers the generic AddObject action for child views. In prior releases, child views registered only their context‑specific add action.

Because most child views in core (and many plugins) already provide a context‑specific add action, the generic registration results in two “Add” buttons on child lists; the generic one also doesn’t pre‑populate the parent context.

Proposal: Remove the generic AddObject registration from ObjectChildrenView (or skip it when a view defines a specific add action).

netbox/netbox/netbox/views/generic/object_views.py

Line 106 in ea50786

actions = (AddObject, BulkImport, BulkEdit, BulkExport, BulkDelete)

I’m happy to open a PR to implement this if the approach sounds reasonable. If there’s background or use‑cases I’m missing, please let me know. Thanks!

[bctiemann]

Sounds reasonable to me; we'll review the PR for any side effects it mght have. Thanks @pheus !