update client code ios build tags to add tvos target#5210
update client code ios build tags to add tvos target#5210shuuri-labs wants to merge 1 commit intomainfrom
Conversation
📝 WalkthroughWalkthroughThis PR expands build constraints across 19 files to include tvOS support alongside iOS (and Android where applicable). All changes are build-tag modifications only—no functional code, API, or logic alterations. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@client/net/listen_ios.go`:
- Line 1: The file contains an invalid Go build constraint using "tvos" which Go
does not recognize; update the build tag in the top of listen_ios.go by removing
the "|| tvos" clause so the build constraint is only "//go:build ios" (locate
the file's existing build line at the very top and replace it accordingly).
🧹 Nitpick comments (2)
client/iface/udpmux/mux_ios.go (1)
1-7: LGTM!The build tag expansion is correct. tvOS shares the same sandboxing restrictions as iOS regarding low-level network hooks, so the no-op implementation is appropriate for both platforms.
💡 Optional: Update the comment to reflect both platforms
func (m *SingleSocketUDPMux) notifyAddressRemoval(addr string) { - // iOS doesn't support nbnet hooks, so this is a no-op + // iOS/tvOS doesn't support nbnet hooks, so this is a no-op }client/internal/routemanager/notifier/notifier_ios.go (1)
1-1: LGTM!The build tag expansion is correct. The iOS-specific networking behavior (no-op stubs for initial routes, network change notifications via listener) applies equally to tvOS.
💡 Optional: Update iOS-specific comments to reflect both platforms
func (n *Notifier) SetInitialClientRoutes([]*route.Route, []*route.Route) { - // iOS doesn't care about initial routes + // iOS/tvOS doesn't care about initial routes } func (n *Notifier) OnNewRoutes(route.HAMap) { - // Not used on iOS + // Not used on iOS/tvOS }



Describe your changes
build tags were added to the ios client code:
go:build ios. these should also reference the tvos target:go:build ios || tvosIssue ticket number and link
Stack
Checklist
Documentation
Select exactly one:
Docs PR URL (required if "docs added" is checked)
Paste the PR link from https://github.com/netbirdio/docs here:
https://github.com/netbirdio/docs/pull/__
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.