Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(platform-fastify): use the route method to inject routes #13493

Merged

Conversation

johaven
Copy link
Contributor

@johaven johaven commented Apr 24, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Route injection is handled by the shorthands methods

What is the new behavior?

As discussed here: fastify/fastify#5412 (comment)

Fastify allows the user to decorate the instance with any name. This can cause problems if common words are used instead of HTTP methods.

The other advantage is that Nest will not depend on the implementation of shorthands methods on the fastify side.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Related to #13278

@coveralls
Copy link

Pull Request Test Coverage Report for Build 04022db3-2466-4895-8ac9-4f29d9445079

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.124%

Totals Coverage Status
Change from base Build b32e22d6-f72e-486a-85a2-044c2b5df08f: 0.0%
Covered Lines: 6737
Relevant Lines: 7313

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit a7e4557 into nestjs:master Jun 3, 2024
3 checks passed
@johaven johaven deleted the refactor-fastify-route-injection branch June 3, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants