Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform-fastify returning 404 on HEAD requests #14016

Closed
2 tasks done
rickdgeerling opened this issue Sep 20, 2024 · 2 comments
Closed
2 tasks done

platform-fastify returning 404 on HEAD requests #14016

rickdgeerling opened this issue Sep 20, 2024 · 2 comments
Labels
needs triage This issue has not been looked into type: bug 😭

Comments

@rickdgeerling
Copy link
Contributor

rickdgeerling commented Sep 20, 2024

Did you read the migration guide?

  • I have read the whole migration guide

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Potential Commit/PR that introduced the regression

#13493

NestJS version

10.3.9

Describe the regression

Previously a HEAD request used to respond with status 200. Now it responds with a 404.

Minimum reproduction code

repoduction repo

Input code

curl -I http://localhost:3000

Expected behavior

Status 200 if the endpoint exists

Other

The new Fastify route(...) supports an array of HTTP methods. The simplest solution might be to just inject routes with method: [method, 'HEAD']

@ansien
Copy link

ansien commented Sep 22, 2024

This is currently breaking all our UptimeRobot monitors (since they use HEAD to check for a 200).

😬

@kamilmysliwiec
Copy link
Member

Let's track this here #14017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage This issue has not been looked into type: bug 😭
Projects
None yet
Development

No branches or pull requests

3 participants