fix(#5545): keep center pane readable in three-panel layout - #5594
3 commits merged into
Conversation
|
Picked up the follow-up fragility Greptile called out in the refreshed summary. |
🎬 Cutter preview — PR #5594
|
🔬 Gate certification — GREEN (engineering) ✅ · ⏸️ visible three-panel layout → Nathan sign-offCertified head: What I ran (rebased worktree
|
| Gate | Result |
|---|---|
| Rebase onto current master | ✅ git apply clean |
| Codex (reproduce) | SAFE TO SHIP — 0 findings |
| PR's layout test | ✅ 5/5 (test_issue5545_three_panel_layout.py) |
Findings
✅ Correct + well-scoped (applied the #5560 media-scope lesson): the new rules live inside @media(min-width:901px) (verified by the enclosing block's closing brace at 2911, not just the nearest @media above) — so .main{flex:1 1 420px; min-width:420px} (center readable floor) + .sidebar/.rightpanel{flex-shrink:1; min-width:180px} (rails shrink first to protect the center) apply ONLY at desktop three-panel widths, NOT mobile/narrow (<901px) — so no 420+180+180 horizontal overflow below 901px; at 901-1200px the 780px min fits. Crucially it adds min-width:0 !important to the COLLAPSED rightpanel selectors so the new min-width:180px can't block a full collapse to 0. Codex confirmed no regression to two-panel / workspace-open / workspace-closed states, no conflict with existing flex rules, collapsed rightpanel still fully collapses. 5 layout tests pass.
Recommendation to the next agent
Engineering-GREEN — merge from branch gate-rebase/5594-three-panel-center-readable (sha:c7997f68), NOT the PR's stale head f34fd8ed — but PARK for Nathan's visual sign-off (three-panel layout at 901 / 1200 / 1440 wide, + verify the rightpanel still fully collapses). The CSS is correctly scoped (≥901px only, no narrow-viewport overflow) and Codex SAFE; the open item is Nathan's visual confirmation that the center-readable floor + rail-shrink behavior looks right across desktop widths (his visual-superiority-at-every-resolution bar). concept 4/5 (real #5545 readability fix). Author @rodboev (T1). crit=3.
Gate-certifier layer (warm-up → gate → release). I do not merge/tag/deploy. Rebased onto current master; verified scope by closing brace (inside @media(min-width:901px), closes 2911 → desktop-only, no <901px overflow), collapsed rightpanel min-width:0 !important preserves full collapse, rails shrink before center, Codex SAFE + 5/5 layout tests. Visible layout → Nathan. Cert valid for sha:c7997f68.
79d3b59
|
Shipped in v0.51.899. Thanks @rodboev — the three-panel desktop layout now keeps the conversation readable on resize: the center gets a floor and the side rails yield first (≥901px; rightpanel still fully collapses when closed). The 910px before/after showed the center going from crushed-unreadable to comfortable. Closes #5545. |


Thinking Path
What Changed
static/style.css: adds a desktop three-panel flex contract that keeps the center pane readable and lets side panels shrink to their existing minimum-width family.static/style.css: keeps the closed desktop workspace panel at a zero-width floor so the new open-panel minimum does not reserve invisible space.tests/test_issue5545_three_panel_layout.py: adds source-level responsive layout tests for the desktop floor, shrinkable rails, and preserved compact/mobile breakpoints.Why It Matters
Users who dock or resize the WebUI with all three panels open keep a usable conversation pane instead of losing it between two fixed side rails.
Verification
python -m pytest tests/test_issue5545_three_panel_layout.py -v --timeout=60git diff --checkFull-suite CI context, not run locally unless requested:
python -m pytest tests/ -v --timeout=60.Upstream
Closes #5545.
Model Used
GPT 5.5 via Codex CLI