fix: title auto-generation + mobile close button (PR #333) + v0.50.10 - #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Picks up PR #333 from ccqqlo (title auto-generation fix + mobile close button) and
adds 11 tests covering both changes.
Changes
api/streaming.py — title auto-generation now fires for
'Untitled','New Chat', and empty string titles.Previously only
'Untitled'was covered; sessions arriving from external forks/clients with'New Chat'as theirdefault title would never get an auto-generated title after the first message.
static/style.css — On viewports ≤900px, both the desktop collapse button (
#btnCollapseWorkspacePanel) andthe mobile X button (
.mobile-close-btn) were rendered simultaneously.Desktop default now hides
.mobile-close-btn; the 900px media query shows it and hides the desktop button.Tests added
tests/test_sprint41.py— 11 tests:'Untitled','New Chat',not s.title, and OR logic.mobile-close-btnhidden by default, shown in 900px query#btnCollapseWorkspacePanelhidden in 900px query, existing rules preservedaria-labelQA
Closes #333