fix: warn on provider mismatch & fix redundant mobile close button - #333
fix: warn on provider mismatch & fix redundant mobile close button#333ccqqlo wants to merge 3 commits into
Conversation
|
Check the diff/files changed, is this PR doing what you expect it to be doing? |
Full Review: PR #333Thanks @ccqqlo! Note: PR title is misleadingThe title says "warn on provider mismatch" but that feature was already merged in PR #283. This PR actually contains:
Both changes are correct and useful, just mislabeled. Security AuditClean. The streaming.py change is a string comparison condition — no user input involved. The CSS change is layout-only. Code Review
if s.title == 'Untitled' or s.title == 'New Chat' or not s.title:Correct.
The 900px media query reformatting (one-line → multi-line) is a readability improvement. Tests735 passed, 0 failed, 48 skipped. No regressions. VerdictApproved. Both changes are correct and low-risk. The PR title should be updated to something like "fix: auto-title new/empty sessions + show mobile close button" but that's cosmetic. |
* fix(merge): preserve auth errors + fix title auto-generation * fix(css): hide mobile close button on desktop for workspace panel * fix: hide duplicate collapse button in mobile workspace panel view * docs: v0.50.10 — title auto-generation fix + mobile close button (PR #333) --------- Co-authored-by: MILO <milo@MILOdeMacMINI-2.local> Co-authored-by: Nathan Esquenazi <nesquena@gmail.com>
Review complete — merged as v0.50.10 ✅Code review: Clean. Both changes are minimal and correct. streaming.py — The expanded title condition ( style.css — PR description note: The description mentions "auth mismatch warnings" — that code was already in master from PR #283. The actual new code in this PR is the title fix + CSS. Not a problem, just context. Tests added (not in original PR): QA results:
Rebased cleanly onto current master (which had moved to v0.50.9 + zh locale fixes since the PR was filed). |
|
@ccqqlo Interested in being a core contributor to this WebUI project? Reach out to me via email (on my profile) or on Twitter if so! |
…v0.50.10 * fix(merge): preserve auth errors + fix title auto-generation * fix(css): hide mobile close button on desktop for workspace panel * fix: hide duplicate collapse button in mobile workspace panel view * docs: v0.50.10 — title auto-generation fix + mobile close button (PR nesquena#333) --------- Co-authored-by: MILO <milo@MILOdeMacMINI-2.local> Co-authored-by: Nathan Esquenazi <nesquena@gmail.com>
…v0.50.10 * fix(merge): preserve auth errors + fix title auto-generation * fix(css): hide mobile close button on desktop for workspace panel * fix: hide duplicate collapse button in mobile workspace panel view * docs: v0.50.10 — title auto-generation fix + mobile close button (PR nesquena#333) --------- Co-authored-by: MILO <milo@MILOdeMacMINI-2.local> Co-authored-by: Nathan Esquenazi <nesquena@gmail.com>
This PR solves two issues:
Auth mismatch warnings (401 errors)
Selecting an OpenRouter model while Hermes is configured for a local provider (or vice-versa) sends the request to the wrong endpoint, which returns a 401 error. This explicitly detects
401/auth errors, preserving theauth_mismatchUI type and surfacing a hint to checkhermes modelrather than failing silently.Redundant Workspace Panel close buttons
When the screen width is <= 900px, both the desktop
#btnCollapseWorkspacePaneland the.mobile-close-btn(X) were shown simultaneously in the Workspace header. This explicitly hides the desktop collapse button under mobile widths so only the X is rendered.