Skip to content

Complete French (fr) locale: +93 missing keys (88.8% → 96.7%) - #2722

Closed
victorwhale wants to merge 1 commit into
nesquena:masterfrom
victorwhale:fr-locale-completion
Closed

victorwhale wants to merge 1 commit into
nesquena:masterfrom
victorwhale:fr-locale-completion

Conversation

@victorwhale

Copy link
Copy Markdown
Contributor

Thinking Path

The FR locale was at 88.8% coverage (1044/1176 keys), behind ES (95.3%), DE (95.2%), IT (99.6%), JA (100%), and ZH (100%). Most missing entries were for command palette descriptions (/background, /branch, /btw, /title, /undo, /retry, /status), kanban board operations, token usage panel, and the folder-to-space upgrade flow — features that have shipped recently and didn't backfill FR strings.

This PR fills those gaps in a single localized pass, preserving the tone and register established by the FR strings already in place.

What Changed

  • static/i18n.js: +93 keys in the fr: block (one logical insertion, grouped under a // === Missing keys (FR translation completion) === marker for review).
  • Coverage: 88.8% → 96.7% (now between DE/ES and IT).
  • No other files touched, no behavior change.

Why It Matters

French users currently see English fallbacks for ~11% of strings, including core command palette entries (`/background`, `/branch`, `/btw`, `/retry`, `/status`, `/title`, `/undo`), the entire token usage panel, kanban board management, and the session status modal. This is a noticeable inconsistency in an otherwise well-localized FR experience.

Verification

  • `node -e "new Function(fs.readFileSync('static/i18n.js','utf8'))"` → OK (syntax valid).
  • Re-ran the missing-keys diff script after the change: 0 of the 93 targeted keys remain missing in FR.
  • All placeholder syntax preserved (`{0}`, `{name}`, etc.).
  • Apostrophes correctly escaped inside single-quoted JS strings (`\'`).

Risks / Follow-ups

  • 39 keys remain missing in FR (now 96.7% coverage). Those are mostly multi-line strings my parser didn't extract on first pass — a follow-up PR can cover them.
  • No screenshots in this PR because the change is exclusively additive i18n strings (no UI structure change). I can attach screenshots of the affected screens in FR if reviewers want visual confirmation.
  • Coverage parity with the more complete locales (IT, JA, ZH) is the obvious next milestone.

Model Used

Claude Opus 4.7 (1M context), with manual review by the PR author.

Adds French translations for 93 i18n keys that were missing from the
fr locale, bringing coverage from 88.8% to 96.7% (1044 → 1137 of 1176 EN keys).

Coverage of common features now complete: background tasks (/background),
fork/branch flows (/branch), side questions (/btw), session status (/status),
title management (/title), undo (/undo), retry flows, kanban board operations,
token usage panel, and folder/space management.

All values keep placeholder syntax intact ({0}, {name}, etc.) and follow the
existing tone established by the FR translations already in place.
@nesquena-hermes

Copy link
Copy Markdown
Collaborator

Shipped in v0.51.107 via release/stage-400 (#2725) — squash-merged so the source branch doesn't auto-close on the keyword.

Thanks for the contribution! Your authorship is preserved via the Co-authored-by trailer on the merged commit.

pull Bot pushed a commit to TKaxv-7S/hermes-webui that referenced this pull request May 21, 2026
…missing keys, 88.8% → 96.7% coverage)

Co-authored-by: victorwhale <victorwhale@users.noreply.github.com>
eleboucher pushed a commit to eleboucher/homelab that referenced this pull request May 22, 2026
…➔ 0.51.107) (#621)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/nesquena/hermes-webui](https://github.com/nesquena/hermes-webui) | patch | `0.51.106` → `0.51.107` |

---

### Release Notes

<details>
<summary>nesquena/hermes-webui (ghcr.io/nesquena/hermes-webui)</summary>

### [`v0.51.107`](https://github.com/nesquena/hermes-webui/blob/HEAD/CHANGELOG.md#v051107--2026-05-21--Release-CE-stage-400--8-PR-batch--pinned-sessions-limit-getter-rename--uploaded-file-user-turn-dedupe--active-run-repair-guard--incremental-KaTeX-streaming--profile-default-model-on-fresh-boot--French-locale-completion--update-check-error-surfacing--release-update-apply-path)

[Compare Source](nesquena/hermes-webui@v0.51.106...v0.51.107)

##### Fixed

- **PR [#&#8203;2718](nesquena/hermes-webui#2718 by [@&#8203;eslicarrillo](https://github.com/eslicarrillo) — Follow-up to v0.51.105's [#&#8203;2700](nesquena/hermes-webui#2700): rename `_pinnedSessionsLimit()` to `_getPinnedSessionsLimit()` so the helper matches the rest of `sessions.js`'s `_get*()` naming convention for accessors. No behavior change.
- **PR [#&#8203;2723](nesquena/hermes-webui#2723 by [@&#8203;ai-ag2026](https://github.com/ai-ag2026) — Deduplicate uploaded-file user turns when the optimistic browser bubble uses plain text but the server-persisted pending turn includes the `[Attached files: ...]` suffix. Previously a turn with attachments could render twice (optimistic + persisted) in the visible transcript before reconciling.
- **PR [#&#8203;2721](nesquena/hermes-webui#2721 by [@&#8203;ai-ag2026](https://github.com/ai-ag2026) — During session repair on restart, treat sessions with a live in-flight run as active. The prior code path could prune restart-stale state for sessions that were actually mid-stream when the server bounced, dropping the resumable run. Now the active-stream check gates the prune so live runs survive a restart cleanly.
- **PR [#&#8203;2710](nesquena/hermes-webui#2710 by [@&#8203;Michaelyklam](https://github.com/Michaelyklam) — Render streamed math (KaTeX) incrementally during a stream so completed expressions render in place as their closing delimiter arrives, instead of all-at-once at the end of the turn. Eliminates the visual flash where prose-with-math sat as raw `\\[...\\]` markup until the final render pass.
- **PR [#&#8203;2709](nesquena/hermes-webui#2709 by [@&#8203;starship-s](https://github.com/starship-s) — On a fresh boot with no persisted model in localStorage, prefer the active profile's configured default model over the static HTML option. Previously a clean install / first-load could surface the placeholder model until the user manually picked a different one, even when the profile had a default configured. Behavior note: the boot path now calls `_clearPersistedModelState()` on each load when no profile default is found, so a previously-persisted user pick is wiped on refresh — this is intentional (matches the PR's "profile default wins on fresh boot" intent and is ratified by `tests/test_model_default_boot_precedence.py`).
- **PR [#&#8203;2722](nesquena/hermes-webui#2722 by [@&#8203;victorwhale](https://github.com/victorwhale) — Complete French (`fr`) locale coverage: +93 missing translation keys covering Settings, profile-ops, gateway tile, skills modal, session controls, and i18n test surfaces. Coverage 88.8% → 96.7%.
- **PR [#&#8203;2717](nesquena/hermes-webui#2717 by [@&#8203;ai-ag2026](https://github.com/ai-ag2026) — Surface update-check fetch errors in the UI instead of failing silently. The background `api/updates/check` request previously swallowed network failures, so an offline / blocked-CDN scenario showed no indication that the version banner couldn't render. Now the failure is logged and exposed to the System panel's update-status card.
- **PR [#&#8203;2719](nesquena/hermes-webui#2719 by [@&#8203;ai-ag2026](https://github.com/ai-ag2026) — Apply release-update target correctly when the user clicks "Check for updates" after a prior dismissal: clears the `sessionStorage` check-once stamp and forces banner re-evaluation. The prior path silently no-op'd because the once-per-tab guard fired before the explicit user click could re-trigger the fetch.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMDEuMSIsInVwZGF0ZWRJblZlciI6IjQzLjEwMS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL3BhdGNoIl19-->

Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/621
SysAdminDoc pushed a commit to SysAdminDoc/hermes-webui that referenced this pull request Jun 26, 2026
…missing keys, 88.8% → 96.7% coverage)

Co-authored-by: victorwhale <victorwhale@users.noreply.github.com>
bernyforce pushed a commit to bernyforce/hermes-webui that referenced this pull request Jul 29, 2026
…missing keys, 88.8% → 96.7% coverage)

Co-authored-by: victorwhale <victorwhale@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants