Skip to content

fix: surface update check fetch errors - #2717

Closed
ai-ag2026 wants to merge 1 commit into
nesquena:masterfrom
ai-ag2026:fix/update-check-fetch-errors
Closed

ai-ag2026 wants to merge 1 commit into
nesquena:masterfrom
ai-ag2026:fix/update-check-fetch-errors

Conversation

@ai-ag2026

Copy link
Copy Markdown
Contributor

Summary

  • surface git fetch failures from the WebUI self-update check instead of reporting green “Up to date”
  • keep locally-known release gaps visible when a tag fetch fails after tags are already present
  • add regression coverage for stale/failing update checks and the manual Settings status path

Root cause

The update checker ran git fetch origin --quiet --tags and returned behind: 0 whenever the fetch failed. The Settings UI only checked whether behind > 0, so an error payload like {behind: 0, error: "fetch failed"} rendered as “Up to date ✓”.

A real failure mode is a local tag that differs from the remote tag (would clobber existing tag ...): the checkout can already know about newer release tags, but the fetch exits non-zero and the current UI masks the problem.

Related reconnaissance

  • Searched open PRs/issues for update-check/fetch/tag/up-to-date overlap; no topical duplicate found.
  • Current origin/master still returns behind: 0 on update-check fetch failures.
  • Some open PRs touch shared frontend files, but none target this update-check error path.

Test plan

  • python3 -m pytest tests/test_updates.py tests/test_update_check_ui.py -q -o addopts=
  • python3 -m pytest tests/test_updates.py tests/test_update_check_ui.py tests/test_regressions.py -q -o addopts=
  • LC_ALL=C LANG=C TZ=UTC python3 -m pytest -q -o addopts=
  • python3 -m compileall -q api tests
  • node --check static/ui.js
  • node --check static/panels.js
  • git diff --check

Note: the unsanitized local full-suite run hit an unrelated locale-sensitive timestamp assertion (10:00 AM expected while Node formatted German 29. März, 10:00). The same full suite passed under neutral LC_ALL=C LANG=C TZ=UTC.

@nesquena-hermes

Copy link
Copy Markdown
Collaborator

Shipped in v0.51.107 via release/stage-400 (#2725) — squash-merged so the source branch doesn't auto-close on the keyword.

Thanks for the contribution! Your authorship is preserved via the Co-authored-by trailer on the merged commit.

pull Bot pushed a commit to TKaxv-7S/hermes-webui that referenced this pull request May 21, 2026
…instead of failing silently

Co-authored-by: ai-ag2026 <ai-ag2026@users.noreply.github.com>
eleboucher pushed a commit to eleboucher/homelab that referenced this pull request May 22, 2026
…➔ 0.51.107) (#621)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/nesquena/hermes-webui](https://github.com/nesquena/hermes-webui) | patch | `0.51.106` → `0.51.107` |

---

### Release Notes

<details>
<summary>nesquena/hermes-webui (ghcr.io/nesquena/hermes-webui)</summary>

### [`v0.51.107`](https://github.com/nesquena/hermes-webui/blob/HEAD/CHANGELOG.md#v051107--2026-05-21--Release-CE-stage-400--8-PR-batch--pinned-sessions-limit-getter-rename--uploaded-file-user-turn-dedupe--active-run-repair-guard--incremental-KaTeX-streaming--profile-default-model-on-fresh-boot--French-locale-completion--update-check-error-surfacing--release-update-apply-path)

[Compare Source](nesquena/hermes-webui@v0.51.106...v0.51.107)

##### Fixed

- **PR [#&#8203;2718](nesquena/hermes-webui#2718 by [@&#8203;eslicarrillo](https://github.com/eslicarrillo) — Follow-up to v0.51.105's [#&#8203;2700](nesquena/hermes-webui#2700): rename `_pinnedSessionsLimit()` to `_getPinnedSessionsLimit()` so the helper matches the rest of `sessions.js`'s `_get*()` naming convention for accessors. No behavior change.
- **PR [#&#8203;2723](nesquena/hermes-webui#2723 by [@&#8203;ai-ag2026](https://github.com/ai-ag2026) — Deduplicate uploaded-file user turns when the optimistic browser bubble uses plain text but the server-persisted pending turn includes the `[Attached files: ...]` suffix. Previously a turn with attachments could render twice (optimistic + persisted) in the visible transcript before reconciling.
- **PR [#&#8203;2721](nesquena/hermes-webui#2721 by [@&#8203;ai-ag2026](https://github.com/ai-ag2026) — During session repair on restart, treat sessions with a live in-flight run as active. The prior code path could prune restart-stale state for sessions that were actually mid-stream when the server bounced, dropping the resumable run. Now the active-stream check gates the prune so live runs survive a restart cleanly.
- **PR [#&#8203;2710](nesquena/hermes-webui#2710 by [@&#8203;Michaelyklam](https://github.com/Michaelyklam) — Render streamed math (KaTeX) incrementally during a stream so completed expressions render in place as their closing delimiter arrives, instead of all-at-once at the end of the turn. Eliminates the visual flash where prose-with-math sat as raw `\\[...\\]` markup until the final render pass.
- **PR [#&#8203;2709](nesquena/hermes-webui#2709 by [@&#8203;starship-s](https://github.com/starship-s) — On a fresh boot with no persisted model in localStorage, prefer the active profile's configured default model over the static HTML option. Previously a clean install / first-load could surface the placeholder model until the user manually picked a different one, even when the profile had a default configured. Behavior note: the boot path now calls `_clearPersistedModelState()` on each load when no profile default is found, so a previously-persisted user pick is wiped on refresh — this is intentional (matches the PR's "profile default wins on fresh boot" intent and is ratified by `tests/test_model_default_boot_precedence.py`).
- **PR [#&#8203;2722](nesquena/hermes-webui#2722 by [@&#8203;victorwhale](https://github.com/victorwhale) — Complete French (`fr`) locale coverage: +93 missing translation keys covering Settings, profile-ops, gateway tile, skills modal, session controls, and i18n test surfaces. Coverage 88.8% → 96.7%.
- **PR [#&#8203;2717](nesquena/hermes-webui#2717 by [@&#8203;ai-ag2026](https://github.com/ai-ag2026) — Surface update-check fetch errors in the UI instead of failing silently. The background `api/updates/check` request previously swallowed network failures, so an offline / blocked-CDN scenario showed no indication that the version banner couldn't render. Now the failure is logged and exposed to the System panel's update-status card.
- **PR [#&#8203;2719](nesquena/hermes-webui#2719 by [@&#8203;ai-ag2026](https://github.com/ai-ag2026) — Apply release-update target correctly when the user clicks "Check for updates" after a prior dismissal: clears the `sessionStorage` check-once stamp and forces banner re-evaluation. The prior path silently no-op'd because the once-per-tab guard fired before the explicit user click could re-trigger the fetch.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMDEuMSIsInVwZGF0ZWRJblZlciI6IjQzLjEwMS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL3BhdGNoIl19-->

Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/621
SysAdminDoc pushed a commit to SysAdminDoc/hermes-webui that referenced this pull request Jun 26, 2026
…instead of failing silently

Co-authored-by: ai-ag2026 <ai-ag2026@users.noreply.github.com>
bernyforce pushed a commit to bernyforce/hermes-webui that referenced this pull request Jul 29, 2026
…instead of failing silently

Co-authored-by: ai-ag2026 <ai-ag2026@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants