New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix deserializing owned hex string #35

Merged

zhangsoledad merged 1 commit into nervosnetwork:master from blckngm:fix-serde

Sep 6, 2023

Contributor

blckngm commented Sep 4, 2023

Fix deserializing owned hex string

We should first deserialize to Cow<str>, or it won't work with a escaped string or crates that don't support deserializing borrowed [u8]/str (e.g. toml, fix: Hex serde deserialize axonweb3/axon#1396).
Don't depend on serde derive, and don't export faster_hex_serde_macros

These are some minor clean-ups. If you don't like them I can remove them.


          fix: fix deserializing owned hex string

9e971ae

and don't depend on serde derive, and don't export
faster_hex_serde_macros

eval-exec approved these changes

View reviewed changes

zhangsoledad added this pull request to the merge queue

Merged via the queue into nervosnetwork:master with commit ba216aa

5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet