fix: Hex serde deserialize

[yangby-cryptape]

What this PR does / why we need it?

This PR fixes:

running 1 test
test types::primitive::tests::test_hex_serde_deserialize ... FAILED

failures:

failures:
    types::primitive::tests::test_hex_serde_deserialize

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 41 filtered out; finished in 0.00s


--- STDERR:              axon-protocol types::primitive::tests::test_hex_serde_deserialize ---
thread 'types::primitive::tests::test_hex_serde_deserialize' panicked at 'called `Result::unwrap()` on an `Err` value: Error { inner: Error { inner: TomlError { message: "invalid type: string \"0x1234\", expected a borrowed byte array", original: Some("\n            key = \"0x1234\"\n        "), keys: ["key"], span: Some(19..27) } } }', protocol/src/types/primitive.rs:546:58
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

What is the impact of this PR?

No Breaking Change

PR relation:

• Ref #

Special notes for your reviewer:

Before this PR, the serde_json already works well:

axon/protocol/src/types/primitive.rs

Lines 564 to 569 in c944e24

	#[test]
	fn test_metadata_json_serialize() {
	let metadata: Metadata = serde_json::from_slice(
	&fs::read("../devtools/genesis-generator/metadata.json").unwrap(),
	)
	.unwrap();

axon/protocol/src/types/primitive.rs

Lines 298 to 302 in c944e24

	pub struct Metadata {
	pub version: MetadataVersion,
	#[cfg_attr(feature = "hex-serialize", serde(serialize_with = "serialize_uint"))]
	pub epoch: u64,
	pub verifier_list: Vec<ValidatorExtend>,

axon/protocol/src/types/primitive.rs

Lines 373 to 375 in c944e24

	pub struct ValidatorExtend {
	pub bls_pub_key: Hex,
	pub pub_key: Hex,

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

• E2E Tests
• Web3 Compatible Tests
• OCT 1-5 And 12-15
• OCT 6-10
• OCT 11
• OCT 16-19
• v3 Core Tests

CI Description

CI Name	Description
Chaos CI	Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy	Run cargo clippy --all --all-targets --all-features
Coverage Test	Get the unit test coverage report
E2E Test	Run end-to-end test to check interfaces
Code Format	Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test	Test the Web3 compatibility of Axon
v3 Core Test	Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19	Run the compatibility tests provided by OpenZeppelin

[github-actions]

The title of this PR does not conform the conventional commits. Please fix it, thx.

[yangby-cryptape]

The title of this PR does not conform the conventional commits. Please fix it, thx.

🆘 If anyone know how to pass this check, please fix the PR title, thx.

p.s. Even the CI looks like it is passed, but in the logs of that CI check, you could find that the check is failed.

[blckngm]

Is this a bug in faster-hex? (It should first de-serialize to String or maybe Cow<str>, not &[u8].)

[yangby-cryptape]

Is this a bug in faster-hex? (It should first de-serialize to String or maybe Cow<str>, not &[u8].)

I checked the following code:

#[serde(transparent)]                                                                                                    
pub struct Hex(#[serde(with = "faster_hex")] Bytes); 

And, it failed, too.

Ref:

• faster-hex official example.
  faster-hex use serde_json for unit tests, too.

I guess:

• serde_json knows every input fields are strings, it parses every fields from string, no matter with quotes or not.
• But serde doesn't, it deserialize all basic types directly (eg, u8, bool), no intermediate type (here, it's string).
  • So, you have to tell serde, parse it to a string, before pass to your customized parser.

[blckngm]

I guess it's because serde_json supports deserializing borrowed str/[u8], but toml doesn't.

It may fail with serde_json too if there are escapes in the json string.