Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ckb-hash depends blake2b-ref multiple times #4172

Merged
merged 7 commits into from
Oct 5, 2023
Merged

Fix ckb-hash depends blake2b-ref multiple times #4172

merged 7 commits into from
Oct 5, 2023

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Sep 28, 2023 •
edited
Loading

What problem does this PR solve?

Problem Summary:
In latest develop branch, we found this:

$ cargo metadata --format-version 1 --all-features --manifest-path ./Cargo.toml
error: the crate `ckb-hash v0.112.0-pre (/home/exec/Projects/github.com/nervosnetwork/ckb/util/hash)` depends on crate `blake2b-ref v0.3.1` multiple times with different names

This PR want to fix this error.

What is changed and how it works?

What's Changed:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec marked this pull request as ready for review September 28, 2023 07:46
@eval-exec eval-exec requested a review from a team as a code owner September 28, 2023 07:46
@eval-exec eval-exec requested review from zhangsoledad, quake and xxuejie and removed request for a team September 28, 2023 07:46
@quake quake added this pull request to the merge queue Sep 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 28, 2023
@quake quake added this pull request to the merge queue Sep 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 29, 2023
@eval-exec eval-exec marked this pull request as draft September 29, 2023 01:52
@eval-exec eval-exec force-pushed the exec/fix-cargo-metadata branch from 0d0f879 to 68cf88f Compare September 29, 2023 01:53
@eval-exec eval-exec marked this pull request as ready for review September 29, 2023 01:55
@yangby-cryptape yangby-cryptape mentioned this pull request Sep 29, 2023
Merged
@quake quake added this pull request to the merge queue Oct 5, 2023
Merged via the queue into nervosnetwork:develop with commit c441010 Oct 5, 2023
33 checks passed
@doitian doitian mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EthanYuan EthanYuan EthanYuan approved these changes

@quake quake quake approved these changes

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad zhangsoledad is a code owner automatically assigned from nervosnetwork/ckb-dev

@xxuejie xxuejie Awaiting requested review from xxuejie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eval-exec @quake @EthanYuan