fix(light-client): could not check MMR for fork chains #4171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
The MMR data are saved as key-value format and the keys are positions (
= block_number - MMR_enabled_block_number
).ckb/store/src/transaction.rs
Lines 371 to 376 in 922516e
So, only the MMR data for main chain could be fetched from the storage.
ckb/util/light-client-protocol-server/src/components/get_last_state_proof.rs
Line 150 in 922516e
What is changed and how it works?
What's Changed:
H
to light client.G
.H
.H
with a incorrect MMR proof to light client.G
to light client.Check List
Tests
Release note