Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cargo doc not generate dependencies type document #3954

Merged
merged 3 commits into from
Apr 23, 2023
Merged

Fix cargo doc not generate dependencies type document #3954

merged 3 commits into from
Apr 23, 2023

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Apr 23, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #3951

Problem Summary:
To avoid potential race conditions, it is recommended to generate documentation for all members in the workspace using the command cargo doc --workspace.

What is changed and how it works?

What's Changed:

Related changes

  • use cargo doc --workspace to generate all crates' documents.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

None: Exclude this PR from the release note.

@eval-exec eval-exec marked this pull request as ready for review April 23, 2023 09:05
@eval-exec eval-exec requested a review from a team as a code owner April 23, 2023 09:05
@eval-exec eval-exec requested review from quake and removed request for a team April 23, 2023 09:05
@eval-exec eval-exec mentioned this pull request Apr 23, 2023
Merged
@eval-exec eval-exec added t:ci Type: CI t:doc Type: Documentation labels Apr 23, 2023
@zhangsoledad zhangsoledad added this pull request to the merge queue Apr 23, 2023
Merged via the queue into nervosnetwork:develop with commit 880ef05 Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@chenyukang chenyukang Awaiting requested review from chenyukang

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad

Assignees
No one assigned
Labels
t:ci Type: CI t:doc Type: Documentation
Projects
CKB Kanban
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type discrepancy in DeploymentInfo between codebase and rpc/README.md documentation
3 participants
@eval-exec @quake @zhangsoledad