rpc(ChainRpc): Add time_added_to_pool field for ChainRpcImpl::get_transaction

[eval-exec]

What problem does this PR solve?

Issue Number: close #3938

Problem Summary:

What is changed and how it works?

What's Changed:

Related changes

• Add time_added_to_pool field to TransactionWithStatus

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code ci-runs-only: [ quick_checks,linters ]

Side effects

• None

Release note

Title Only: Include only the PR title in the release note.

[eval-exec]

I think there may be a bug in the make gen-rpc-doc command.

Investigating...

---

Update: It seems that if I write multiple lines of comments to a field for a struct, make gen-rpc-doc may get unexpected result.

Waiting #3954 to solve rpc doc issue.

[doitian]

I asked AI to give a better name:

Some better name options for enter_tx_pool_timestamp could be:

• tx_pool_entry_timestamp
• timestamp_entered_tx_pool
• tx_pool_inclusion_time
• time_added_to_tx_pool
  These names are a bit more verbose but convey the meaning clearly that it is the timestamp when the transaction entered the transaction pool.

I think we can use time_added_to_pool. The prefix tx_ is not necessary.

[eval-exec]

Agree. ❤️

[eval-exec]

--- STDERR:              ckb-rpc tests::examples::test_rpc_examples ---
thread 'tests::examples::test_rpc_examples' panicked at 'assertion failed: `(left == right)`: RPC Example get_transaction(id=42) got the following unexpected response:

{"id":42,"jsonrpc":"2.0","result":{"cycles":"0x219","time_added_to_pool":"0x187b3d137a1","transaction":{"cell_deps":[{"dep_type":"code","out_point":{"index":"0x0","tx_hash":"0xa4037a893eb48e18ed4ef61034ce26eba9c585f15c9cee102ae58505565eccc3"}}],"hash":"0xa0ef4eb5f4ceeb08a4c8524d84c5da95dce2f608e0ca2ec8091191b0f330c6e3","header_deps":["0x7978ec7ce5b507cfb52e149e36b1a23f6062ed150503c85bbf825da3599095ed"],"inputs":[{"previous_output":{"index":"0x0","tx_hash":"0x365698b50ca0da75dca2c87f9e7b563811d3b5813736b8cc62cc3b106faceb17"},"since":"0x0"}],"outputs":[{"capacity":"0x2540be400","lock":{"args":"0x","code_hash":"0x28e83a1277d48add8e72fadaa9248559e1b632bab2bd60b27955ebc4c03800a5","hash_type":"data"},"type":null}],"outputs_data":["0x"],"version":"0x0","witnesses":[]},"tx_status":{"block_hash":null,"reason":null,"status":"pending"}},"error":null}

Diff < left / right > :
 RpcTestResponse {
     id: 42,
     jsonrpc: "2.0",
     result: Object {
         "cycles": String("0x219"),
>        "time_added_to_pool": String("0x187b3d137a1"),
         "transaction": Object {
             "cell_deps": Array [
                 Object {
                     "dep_type": String("code"),
                     "out_point": Object {
                         "index": String("0x0"),
                         "tx_hash": String("0xa4037a893eb48e18ed4ef61034ce26eba9c585f15c9cee102ae58505565eccc3"),
                     },
                 },
             ],
             "hash": String("0xa0ef4eb5f4ceeb08a4c8524d84c5da95dce2f608e0ca2ec8091191b0f330c6e3"),
             "header_deps": Array [
                 String("0x7978ec7ce5b507cfb52e149e36b1a23f6062ed150503c85bbf825da3599095ed"),
             ],
             "inputs": Array [
                 Object {
                     "previous_output": Object {
                         "index": String("0x0"),
                         "tx_hash": String("0x365698b50ca0da75dca2c87f9e7b563811d3b5813736b8cc62cc3b106faceb17"),
                     },
                     "since": String("0x0"),
                 },
             ],
             "outputs": Array [
                 Object {
                     "capacity": String("0x2540be400"),
                     "lock": Object {
                         "args": String("0x"),
                         "code_hash": String("0x28e83a1277d48add8e72fadaa9248559e1b632bab2bd60b27955ebc4c03800a5"),
                         "hash_type": String("data"),
                     },
                     "type": Null,
                 },
             ],
             "outputs_data": Array [
                 String("0x"),
             ],
             "version": String("0x0"),
             "witnesses": Array [],
         },
         "tx_status": Object {
             "block_hash": Null,
             "reason": Null,
             "status": String("pending"),
         },
     },
     error: Null,
 }

', rpc/src/tests/examples.rs:560:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

https://github.com/nervosnetwork/ckb/actions/runs/4786689804/jobs/8510943774

It's hard to let this RPC pass RpcTestExample, thinking...

Update: In latest commit, I reset Example json value of time_added_to_pool to RpcTestExample's response value. Then all of the unit tests passed.

I think this PR is ready for merge.