Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Display live cells of a specific address #1597

Merged
merged 16 commits into from
Jun 7, 2024

Conversation

devchenyan
Copy link

Copy link

vercel bot commented May 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ckb-explorer-frontend-in-nervosnetwork-repo ✅ Ready (Inspect) Visit Preview Jun 6, 2024 1:58am

@Keith-CY
Copy link
Collaborator

Conflicted

@Keith-CY
Copy link
Collaborator

@FrederLu please have a test

@Keith-CY
Copy link
Collaborator

Screen.Recording.2024-05-14.at.22.39.20.mov

Icons in tooltip should be be scrolled together

@Keith-CY
Copy link
Collaborator

Loading is not properly added

image

It looks like that the list is empty

@FrederLu
Copy link

FrederLu commented May 15, 2024

Preview https://ckb-explorer-frontend-in-nervosnetwork-re-git-8e729c-magickbase.vercel.app/

https://ckb-explorer-frontend-in-nervosnetwork-re-git-8e729c-magickbase.vercel.app/address/ckt1qpwlcrypp304tdyn65er6mxqp4fszg2jhj299a3h5w593n8uz6u5cqs86u8xw
image
image
1、The address page displays abnormally.
https://ckb-explorer-frontend-in-nervosnetwork-re-git-8e729c-magickbase.vercel.app/en/address/ckt1qzda0cr08m85hc8jlnfp3zer7xulejywt49kt2rr0vthywaa50xwsqf2jfrvmy0hvkptf6t43292yg2p9yygxyc94v2z8

2024-05-15.11.49.10.mov

https://ckb-explorer-frontend-in-nervosnetwork-re-git-8e729c-magickbase.vercel.app/en/address/ckt1qzda0cr08m85hc8jlnfp3zer7xulejywt49kt2rr0vthywaa50xwsq0rjr2tndx8vdlvspuehkhkgjhxyhxmjgsqw8hsk


https://ckb-explorer-frontend-in-nervosnetwork-re-git-8e729c-magickbase.vercel.app/en/address/ckt1qzda0cr08m85hc8jlnfp3zer7xulejywt49kt2rr0vthywaa50xwsqf76dahct9rrku3nhjfpq2x48a78q04c8sylldjp
image
image

2、Switch to card form through the format and find that the newly added time is blocked.


image 3、It is best if the switch button also has a hover prompt. cc @Sven-TBD

https://ckb-explorer-frontend-in-nervosnetwork-re-git-8e729c-magickbase.vercel.app/en/address/ckt1qrfrwcdnvssswdwpn3s9v8fp87emat306ctjwsm3nmlkjg8qyza2cqgqqynrldgpu7chr7psp6yf035kfxz42zlraslev0fl
image
image
4、Discovered through Detail that omiga_inscription should appear as xUDT.


image image image

https://ckb-explorer-frontend-in-nervosnetwork-re-git-8e729c-magickbase.vercel.app/en/address/ckt1qpvvtay34wndv9nckl8hah6fzzcltcqwcrx79apwp2a5lkd07fdxxq2tcwf8z9lvrtr96w84lt9f4g243kspt4qk0rvv3

5、Pay attention to the several types under Type, as well as the capitalization.
At the same time, there are currently 4 types of NFT included.

@devchenyan
Copy link
Author

@zmcNotafraid @Sven-TBD Please pay attention to the several types under Type, as well as the capitalization.

@Sven-TBD
Copy link

Sven-TBD commented May 15, 2024

3、It is best if the switch button also has a hover prompt. cc @Sven-TBD

Yes, please add a hover status on it. @devchenyan @FrederLu

It could be “Show as list view” and "Show as card view"

@devchenyan
Copy link
Author

devchenyan commented May 15, 2024

1、UI designer suggest tweaking the presentation this way
image

@FrederLu
Copy link

FrederLu commented May 17, 2024

@FrederLu
Copy link

4、Discovered through Detail that omiga_inscription should appear as xUDT.
5、Pay attention to the several types under Type, as well as the capitalization.
At the same time, there are currently 4 types of NFT included.

6、Type is not displaying data correctly.
7、Amount data is displayed abnormally.

Preview https://ckb-explorer-frontend-in-nervosnetwork-re-git-8e729c-magickbase.vercel.app/
Several data issues mentioned above still exist on Preview.

@Sven-TBD
Copy link

image

There should be a config here, if the amount is unknown, then the unit should not be displayed.

@Sven-TBD
Copy link

image And please pin these headers @devchenyan

@Keith-CY
Copy link
Collaborator

How is it going @Sven-TBD

@devchenyan
Copy link
Author

@FrederLu please test it again

@FrederLu
Copy link

4、Discovered through Detail that omiga_inscription should appear as xUDT.
5、Pay attention to the several types under Type, as well as the capitalization.
At the same time, there are currently 4 types of NFT included.

6、Type is not displaying data correctly.
7、Amount data is displayed abnormally.

Preview https://ckb-explorer-frontend-in-nervosnetwork-re-git-8e729c-magickbase.vercel.app/ Several data issues mentioned above still exist on Preview.

Fix verified.


image And please pin these headers @devchenyan

https://ckb-explorer-frontend-in-nervosnetwork-re-git-8e729c-magickbase.vercel.app/address/ckt1qpvvtay34wndv9nckl8hah6fzzcltcqwcrx79apwp2a5lkd07fdxxq2tcwf8z9lvrtr96w84lt9f4g243kspt4qk0rvv3
image
9、I found that the list data of this address can still be slid left and right and is not fixed.


https://ckb-explorer-frontend-in-nervosnetwork-re-git-8e729c-magickbase.vercel.app/address/ckt1qzda0cr08m85hc8jlnfp3zer7xulejywt49kt2rr0vthywaa50xwsqf9umzklmetha4et0ndxuwj7x3n93jf88sqws3a7
image
image

10、The bottom type shows that the data Amount of unique_cell is UNKNOWN, and the type needs to refer to prd to display Unkown. cc @Sven-TBD

@devchenyan
Copy link
Author

4、Discovered through Detail that omiga_inscription should appear as xUDT.
5、Pay attention to the several types under Type, as well as the capitalization.
At the same time, there are currently 4 types of NFT included.

6、Type is not displaying data correctly.
7、Amount data is displayed abnormally.

Preview https://ckb-explorer-frontend-in-nervosnetwork-re-git-8e729c-magickbase.vercel.app/ Several data issues mentioned above still exist on Preview.

Fix verified.

image And please pin these headers @devchenyan

https://ckb-explorer-frontend-in-nervosnetwork-re-git-8e729c-magickbase.vercel.app/address/ckt1qpvvtay34wndv9nckl8hah6fzzcltcqwcrx79apwp2a5lkd07fdxxq2tcwf8z9lvrtr96w84lt9f4g243kspt4qk0rvv3 image 9、I found that the list data of this address can still be slid left and right and is not fixed.

https://ckb-explorer-frontend-in-nervosnetwork-re-git-8e729c-magickbase.vercel.app/address/ckt1qzda0cr08m85hc8jlnfp3zer7xulejywt49kt2rr0vthywaa50xwsqf9umzklmetha4et0ndxuwj7x3n93jf88sqws3a7 image image

10、The bottom type shows that the data Amount of unique_cell is UNKNOWN, and the type needs to refer to prd to display Unkown. cc @Sven-TBD

9、Header scrolling up and down has been fixed. But there is due to the page width, this left and right can be scrolled, otherwise it may not be displayed.

10、fixed

@Sven-TBD
Copy link

9、We can provide the view for a minimal width, when the width is less than the minimal width, we can just hide the table and add a tip saying that "This table is hidden because the width is too narrow."
BTW, considering we are going to uniform the UI, could we make some rules for the element under different widths. @Kirl70

@Kirl70
Copy link

Kirl70 commented May 31, 2024

9、We can provide the view for a minimal width, when the width is less than the minimal width, we can just hide the table and add a tip saying that "This table is hidden because the width is too narrow." BTW, considering we are going to uniform the UI, could we make some rules for the element under different widths. @Kirl70

The minimum width of the table is the size of the mobile screen. on mobile devices, the table can still be scrolled. References:
https://www.figma.com/design/6XNoimRDbFTTNm016rbIdU/Magickbase?node-id=37529%3A55394&t=abVo0S1TKwoKLpYh-1
image

@FrederLu
Copy link

9、Header scrolling up and down has been fixed. But there is due to the page width, this left and right can be scrolled, otherwise it may not be displayed.

https://ckb-explorer-frontend-in-nervosnetwork-re-git-8e729c-magickbase.vercel.app/address/ckt1qpvvtay34wndv9nckl8hah6fzzcltcqwcrx79apwp2a5lkd07fdxxq2tcwf8z9lvrtr96w84lt9f4g243kspt4qk0rvv3
image
image
If the reason is that the Amount data is too long, you can refer to the amount data display style under the User Defined Token tab. @devchenyan

@Keith-CY
Copy link
Collaborator

Keith-CY commented Jun 3, 2024

9、Header scrolling up and down has been fixed. But there is due to the page width, this left and right can be scrolled, otherwise it may not be displayed.

ckb-explorer-frontend-in-nervosnetwork-re-git-8e729c-magickbase.vercel.app/address/ckt1qpvvtay34wndv9nckl8hah6fzzcltcqwcrx79apwp2a5lkd07fdxxq2tcwf8z9lvrtr96w84lt9f4g243kspt4qk0rvv3 image image If the reason is that the Amount data is too long, you can refer to the amount data display style under the User Defined Token tab. @devchenyan

Any update on this @devchenyan

@Keith-CY
Copy link
Collaborator

Keith-CY commented Jun 5, 2024

9、Header scrolling up and down has been fixed. But there is due to the page width, this left and right can be scrolled, otherwise it may not be displayed.

ckb-explorer-frontend-in-nervosnetwork-re-git-8e729c-magickbase.vercel.app/address/ckt1qpvvtay34wndv9nckl8hah6fzzcltcqwcrx79apwp2a5lkd07fdxxq2tcwf8z9lvrtr96w84lt9f4g243kspt4qk0rvv3 image image If the reason is that the Amount data is too long, you can refer to the amount data display style under the User Defined Token tab. @devchenyan

Any update on this @devchenyan

@devchenyan please check or update an ETA for this PR

@devchenyan
Copy link
Author

9、Header scrolling up and down has been fixed. But there is due to the page width, this left and right can be scrolled, otherwise it may not be displayed.

https://ckb-explorer-frontend-in-nervosnetwork-re-git-8e729c-magickbase.vercel.app/address/ckt1qpvvtay34wndv9nckl8hah6fzzcltcqwcrx79apwp2a5lkd07fdxxq2tcwf8z9lvrtr96w84lt9f4g243kspt4qk0rvv3 image image If the reason is that the Amount data is too long, you can refer to the amount data display style under the User Defined Token tab. @devchenyan

@FrederLu fixed
image

@FrederLu
Copy link

FrederLu commented Jun 6, 2024

9、Header scrolling up and down has been fixed. But there is due to the page width, this left and right can be scrolled, otherwise it may not be displayed.

https://ckb-explorer-frontend-in-nervosnetwork-re-git-8e729c-magickbase.vercel.app/address/ckt1qpvvtay34wndv9nckl8hah6fzzcltcqwcrx79apwp2a5lkd07fdxxq2tcwf8z9lvrtr96w84lt9f4g243kspt4qk0rvv3 image image If the reason is that the Amount data is too long, you can refer to the amount data display style under the User Defined Token tab. @devchenyan

@FrederLu fixed image

PR verified. cc @Keith-CY

@Keith-CY Keith-CY merged commit f68e0c9 into nervosnetwork:develop Jun 7, 2024
2 checks passed
@Keith-CY Keith-CY deleted the feature/display-live-cells branch June 7, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants