Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display live cells of a specific address #19

Open
Keith-CY opened this issue May 8, 2022 · 18 comments
Open

Display live cells of a specific address #19

Keith-CY opened this issue May 8, 2022 · 18 comments
Assignees
Labels
enhancement New feature or request

Comments

@Keith-CY
Copy link
Member

Keith-CY commented May 8, 2022

Cell info

{
    lock: {
      code_hash: "0x9bd7e06f3ecf4be0f2fcd2188b23f1b9fcc88e5d4b65a8637b17723bbda3cce8",
      hash_type: "type",
      args: "0xe2fa82e70b062c8644b80ad7ecf6e015e5f352f6",
    },
    type: {
      code_hash: "0x9bd7e06f3ecf4be0f2fcd2188b23f1b9fcc88e5d4b65a8637b17723bbda3cce8",
      hash_type: "type",
      args: "0xe2fa82e70b062c8644b80ad7ecf6e015e5f352f6",
    },
    out_point: {
      tx_hash: "0xdf45112919d4af12b10fed94a93798ae6ddd8c89a11d90980022dcf695babca9",
      index: "0x0",
    },
    capacity: "0x2540be400",
    data: "0x",
  }
  1. lock: mark script tag
  2. type: mark script tag
  3. out_point: link to tx page
  4. capacity: in variant formats(hex, int)
  5. data: in various formats(hex, utf8)
@Keith-CY Keith-CY added the enhancement New feature or request label May 8, 2022
@Keith-CY Keith-CY added this to the 2022/05/11 - 2022/05/18 milestone May 8, 2022
@Keith-CY Keith-CY self-assigned this May 8, 2022
@Keith-CY Keith-CY added feature and removed enhancement New feature or request labels Jun 8, 2022
@Keith-CY
Copy link
Member Author

  1. select and export
  2. filtered by script hash
  3. sorted by capacity/script/outpoint
checkbox | outpoint | lock script tag(click for dialog) | type script tag(click for dialog) | capacity(convert formats) | data(convert formats)

@ShiningRay
Copy link
Contributor

新接口我打算在新的路径下进行开发 /api/v2

@Keith-CY
Copy link
Member Author

新接口我打算在新的路径下进行开发 /api/v2

好的, v2 的接口我们考虑对外部支持, 可以针对 DApp 设计一下, 不用考虑浏览器的需求

@ShiningRay
Copy link
Contributor

新接口我打算在新的路径下进行开发 /api/v2

好的, v2 的接口我们考虑对外部支持, 可以针对 DApp 设计一下, 不用考虑浏览器的需求

你对这个数据结构有什么想法,就是 Cell 需要哪些字段

@Keith-CY
Copy link
Member Author

新接口我打算在新的路径下进行开发 /api/v2

好的, v2 的接口我们考虑对外部支持, 可以针对 DApp 设计一下, 不用考虑浏览器的需求

你对这个数据结构有什么想法,就是 Cell 需要哪些字段

我觉得需要的数据是第一条信息里的 cell 数据结构, 考虑显示友好性的话还希望加上是否是已知的 script, 不过已知 script 可以单独做一个接口

@Keith-CY Keith-CY removed this from the 2022/06/22 - 2022/06/29 milestone Jun 29, 2022
@Keith-CY Keith-CY assigned Danie0918 and unassigned ShiningRay and Keith-CY Feb 17, 2023
@Keith-CY
Copy link
Member Author

This is a desirable feature we'll support later, please have a look and any suggestion could be added in this issue @Danie0918

@Sven-TBD Sven-TBD self-assigned this Nov 20, 2023
@Sven-TBD
Copy link
Contributor

Sven-TBD commented Dec 8, 2023

@Keith-CY I made a prototype on this requirement, PRD here, however I did not completely follow the original requirement description.

And I'd like to post a question here. Is there a UID(Unique identification) of a specific live cell? Like the hash of it. If so, I can title/name these different live cells.

@Keith-CY
Copy link
Member Author

Keith-CY commented Dec 9, 2023

@Keith-CY I made a prototype on this requirement, PRD here, however I did not completely follow the original requirement description.

And I'd like to post a question here. Is there a UID(Unique identification) of a specific live cell? Like the hash of it. If so, I can title/name these different live cells.

Sure, each cell has its own unique index, it's called outPoint(https://github.com/nervosnetwork/rfcs/blob/master/rfcs/0019-data-structures/0019-data-structures.md#outpoint) and consists of two fields

  • transaction hash: the transaction generates this cell
  • index: the position of the cell in the transaction

When a cell is referenced, its outpoint will be mentioned, e.g. inputs of a transaction

@Kirl70
Copy link

Kirl70 commented Dec 27, 2023

Design Draft (1-3--1-6):
https://www.figma.com/file/6XNoimRDbFTTNm016rbIdU/Magickbase?type=design&node-id=31495%3A29631&mode=design&t=yZJTO5TQ5sYnY7Bg-1
image

@Keith-CY
Copy link
Member Author

Keith-CY commented May 6, 2024

Sort by block number is held on due to API missing

@Keith-CY
Copy link
Member Author

Keith-CY commented May 6, 2024

image

Feedback to the grid view

  1. UID is a new concept(unique index of a cell, based on hash or other) but it works as Output(which should be named Out Point), clicking it leads to the transaction page;
  2. Block info could be expanded by hovering on Block # and DATE can be included in the expanded info;

cc @Sven-TBD

@Danie0918 Danie0918 assigned devchenyan and unassigned Sven-TBD and Kirl70 May 6, 2024
@Sven-TBD
Copy link
Contributor

Sven-TBD commented May 7, 2024

image Feedback to the grid view
  1. UID is a new concept(unique index of a cell, based on hash or other) but it works as Output(which should be named Out Point), clicking it leads to the transaction page;
  2. Block info could be expanded by hovering on Block # and DATE can be included in the expanded info;

cc @Sven-TBD

The list view of Live Cell Tab have been updated. Only labels have been changed, there's no UI change here. cc @Kirl70
image

Please be attention, this list view is only for Live cells tab. For other tabs, the labels should be adjusted as well. @devchenyan cc @Keith-CY

@Keith-CY
Copy link
Member Author

Keith-CY commented May 7, 2024

image Feedback to the grid view
  1. UID is a new concept(unique index of a cell, based on hash or other) but it works as Output(which should be named Out Point), clicking it leads to the transaction page;
  2. Block info could be expanded by hovering on Block # and DATE can be included in the expanded info;

cc @Sven-TBD

The list view of Live Cell Tab have been updated. Only labels have been changed, there's no UI change here. cc @Kirl70 image

Please be attention, this list view is only for Live cells tab. For other tabs, the labels should be adjusted as well. @devchenyan cc @Keith-CY

Now NFT has been divided into 2 types

@Sven-TBD
Copy link
Contributor

Sven-TBD commented May 7, 2024

  • NFT:

@zmcNotafraid @rabbitz Hi mc, nan, We may need to add a Type label and a Block height label for the live cells api.

Also serial numbers should also be added to the list view. @devchenyan
image

@Sven-TBD
Copy link
Contributor

Sven-TBD commented May 8, 2024

@devchenyan can you provide a ETA for the list view of live cells tab?

@devchenyan
Copy link

@devchenyan can you provide a ETA for the list view of live cells tab?

5.10

@zmcNotafraid
Copy link
Member

  • NFT:

@zmcNotafraid @rabbitz Hi mc, nan, We may need to add a Type label and a Block height label for the live cells api.

Also serial numbers should also be added to the list view. @devchenyan image

Current API was supported.For block_height in api is block_number, for type in api is extra_info's type

@devchenyan
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🚩Pre Release
Status: Todo
Development

No branches or pull requests

7 participants