Improve ns-process-data images when using existing COLMAP model #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen using --skip-colmap on images.bin with non-standard image names
tancik
reviewed
Feb 7, 2023
scripts/process_data.py
Outdated
| @@ -74,6 +74,10 @@ class ProcessImages: | |||
| will downscale the images by 2x, 4x, and 8x.""" | |||
| skip_colmap: bool = False | |||
| """If True, skips COLMAP and generates transforms.json if possible.""" | |||
| skip_images: bool = False | |||
There was a problem hiding this comment.
Make more descriptive, -> skip_image_processing
yimingzhou1
added a commit
to parallelsystems/nerfstudio
that referenced
this pull request
Feb 7, 2023
* Fix normals visualization (nerfstudio-project#1341) * Fix depth-supervised nerf when using z-buffer depth. (nerfstudio-project#1340) * fix z buffer depth * remove script * Create shaders (nerfstudio-project#1344) * New config parameter --viewer.codec defaults to VP8, but allows H264 (nerfstudio-project#1343) * New config parameter --viewer.codec defaults to H264 rather than VP8 * make quantize clearer * change codec to Literal default is VP8 due to libx264 log spam, see nerfstudio-project#1343 (comment) * isort * pylint, including python 3.7 compatibility * double-quote filenames in process-data commands so that on Windows, paths with spaces don't fail (nerfstudio-project#1347) * double-quote filenames in commands so that on Windows, paths with spaces don't fail * reformatting by black * Improve viewer colormap choices (nerfstudio-project#1348) * Consistent naming for depth maps in Polycam (nerfstudio-project#1352) * Handle uncalibrated Metashape sensor (nerfstudio-project#1359) This fix allows loading Metashape XML files which contain an additional uncalibrated sensor. Metashape XML format keeps unmatched images but assignes a dummy sensor to them. The sensor has no calibration data. Co-authored-by: gilureta <[email protected]> * add viewer.local config property when viewing local instance (nerfstudio-project#1358) If running local server instance, avoid using relays to communicate with the viewer. * Allow methods configs to be discovered from external packages. (nerfstudio-project#1357) * Allow method_config to be registered from external packages * Add license * Add MethodSpecification class + fix linter errors --------- * Trace Stable Diffusion (nerfstudio-project#1362) * Trace Stable Diffusion * pylint Co-authored by Terrance Wang * Fix ns-train help (nerfstudio-project#1370) * Improve ns-process-data images when using existing COLMAP model (nerfstudio-project#1371) * Allow skipping copy+downscale of images in ns-process-data, fix bug when using --skip-colmap on images.bin with non-standard image names * Rename flags and improve error messages --------- Co-authored-by: Matthew Tancik <[email protected]> --------- Co-authored-by: Matthew Tancik <[email protected]> Co-authored-by: Jeffrey Hu <[email protected]> Co-authored-by: machenmusik <[email protected]> Co-authored-by: ManuConcepBrito <[email protected]> Co-authored-by: Francisca T. Gil Ureta <[email protected]> Co-authored-by: gilureta <[email protected]> Co-authored-by: Jonáš Kulhánek <[email protected]>
chris838
pushed a commit
to chris838/nerfstudio
that referenced
this pull request
Apr 22, 2023
…studio-project#1371) * Allow skipping copy+downscale of images in ns-process-data, fix bug when using --skip-colmap on images.bin with non-standard image names * Rename flags and improve error messages --------- Co-authored-by: Matthew Tancik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the following:
NOTE: I accidentally closed PR #1366. This PR contains the same changes.