Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New config parameter --viewer.codec defaults to VP8, but allows H264 #1343

Merged
merged 6 commits into from
Feb 3, 2023

Conversation

machenmusik
Copy link
Contributor

Fixes #1325.

@tancik
Copy link
Contributor

tancik commented Feb 3, 2023

Im fine with making H264 the default, but Im curious, are there any specific reasons to prefer it over VP8?

Also with H264 I see alot of spurious printing
image

@machenmusik
Copy link
Contributor Author

machenmusik commented Feb 3, 2023

H264 has better compression (perhaps better for remote viewers) -- and may facilitate hardware encoding, which should be somewhat faster / less burdensome for the server.

Not sure where the log spam from libx264 is from, probably somewhere in aiortc etc.?
If we can't figure out how to quash, and it's annoying, feel free to change default from H264 back to VP8
(although then we should change the description).

@tancik
Copy link
Contributor

tancik commented Feb 3, 2023

I've dug around and haven't found any obvious ways to disable the logging. Lets keep the default to VP8 for now and then consider changing if we figure it out.

default is VP8 due to libx264 log spam, see nerfstudio-project#1343 (comment)
@machenmusik
Copy link
Contributor Author

Done.
(What I've seen about PyAV logging doesn't seem to work on the libx264 spam...)

@machenmusik
Copy link
Contributor Author

Sidebar: I notice that when doing dynamic image size calculation (e.g. changing viewer position/orientation), there are quite a number of different sizes, which seem to cause a good number of encoder changes. I wonder it would be better to have fewer discrete sub-frame sizes, to thrash a bit less, similar to downsampling... but that's probably more important if hardware encoding.

@machenmusik machenmusik changed the title New config parameter --viewer.codec defaults to H264 rather than VP8 New config parameter --viewer.codec defaults to VP8, but allows H264 Feb 3, 2023
Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tancik tancik merged commit 319a2b9 into nerfstudio-project:main Feb 3, 2023
yimingzhou1 added a commit to parallelsystems/nerfstudio that referenced this pull request Feb 7, 2023
* Fix normals visualization (nerfstudio-project#1341)

* Fix depth-supervised nerf when using z-buffer depth. (nerfstudio-project#1340)

* fix z buffer depth

* remove script

* Create shaders (nerfstudio-project#1344)

* New config parameter --viewer.codec defaults to VP8, but allows H264 (nerfstudio-project#1343)

* New config parameter --viewer.codec defaults to H264 rather than VP8

* make quantize clearer

* change codec to Literal

default is VP8 due to libx264 log spam, see nerfstudio-project#1343 (comment)

* isort

* pylint, including python 3.7 compatibility

* double-quote filenames in process-data commands so that on Windows, paths with spaces don't fail (nerfstudio-project#1347)

* double-quote filenames in commands so that on Windows, paths with spaces don't fail

* reformatting by black

* Improve viewer colormap choices (nerfstudio-project#1348)

* Consistent naming for depth maps in Polycam (nerfstudio-project#1352)

* Handle uncalibrated Metashape sensor (nerfstudio-project#1359)

This fix allows loading Metashape XML files which
contain an additional uncalibrated sensor.

Metashape XML format keeps unmatched images but
assignes a dummy sensor to them. The sensor has
no calibration data.

Co-authored-by: gilureta <[email protected]>

* add viewer.local config property when viewing local instance (nerfstudio-project#1358)

If running local server instance, avoid using relays to communicate with the viewer.

* Allow methods configs to be discovered from external packages. (nerfstudio-project#1357)

* Allow method_config to be registered from external packages

* Add license

* Add MethodSpecification class + fix linter errors

---------

* Trace Stable Diffusion (nerfstudio-project#1362)

* Trace Stable Diffusion

* pylint

Co-authored by Terrance Wang

* Fix ns-train help (nerfstudio-project#1370)

* Improve ns-process-data images when using existing COLMAP model (nerfstudio-project#1371)

* Allow skipping copy+downscale of images in ns-process-data, fix bug when using --skip-colmap on images.bin with non-standard image names

* Rename flags and improve error messages

---------

Co-authored-by: Matthew Tancik <[email protected]>

---------

Co-authored-by: Matthew Tancik <[email protected]>
Co-authored-by: Jeffrey Hu <[email protected]>
Co-authored-by: machenmusik <[email protected]>
Co-authored-by: ManuConcepBrito <[email protected]>
Co-authored-by: Francisca T. Gil Ureta <[email protected]>
Co-authored-by: gilureta <[email protected]>
Co-authored-by: Jonáš Kulhánek <[email protected]>
machenmusik added a commit to machenmusik/nerfstudio that referenced this pull request Feb 20, 2023
default is VP8 due to libx264 log spam, see nerfstudio-project#1343 (comment)
machenmusik added a commit to machenmusik/nerfstudio that referenced this pull request Feb 23, 2023
default is VP8 due to libx264 log spam, see nerfstudio-project#1343 (comment)
machenmusik added a commit to machenmusik/nerfstudio that referenced this pull request Feb 23, 2023
default is VP8 due to libx264 log spam, see nerfstudio-project#1343 (comment)
machenmusik added a commit to machenmusik/nerfstudio that referenced this pull request Feb 25, 2023
default is VP8 due to libx264 log spam, see nerfstudio-project#1343 (comment)
machenmusik added a commit to machenmusik/nerfstudio that referenced this pull request Feb 27, 2023
default is VP8 due to libx264 log spam, see nerfstudio-project#1343 (comment)
machenmusik added a commit to machenmusik/nerfstudio that referenced this pull request Feb 27, 2023
default is VP8 due to libx264 log spam, see nerfstudio-project#1343 (comment)
machenmusik added a commit to machenmusik/nerfstudio that referenced this pull request Mar 2, 2023
default is VP8 due to libx264 log spam, see nerfstudio-project#1343 (comment)
chris838 pushed a commit to chris838/nerfstudio that referenced this pull request Apr 22, 2023
…erfstudio-project#1343)

* New config parameter --viewer.codec defaults to H264 rather than VP8

* make quantize clearer

* change codec to Literal

default is VP8 due to libx264 log spam, see nerfstudio-project#1343 (comment)

* isort

* pylint, including python 3.7 compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

odd width and/or height prevent viewer from using H264 instead of VP8
2 participants