Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop leaking BackgroundPurges #8650

Merged
merged 6 commits into from
Aug 8, 2024
Merged

fix: stop leaking BackgroundPurges #8650

merged 6 commits into from
Aug 8, 2024

Commits on Aug 8, 2024

  1. fix: stop leaking BackgroundPurges 

    avoid "leaking" the completions of BackgroundPurges by:

1. switching it to TaskTracker for provided close+wait
2. stop using tokio::fs::remove_dir_all which will consume two units of
   memory instead of one std::fs::remove_dir_all
    @koivunej
    koivunej committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    d79da8f View commit details
    Browse the repository at this point in the history

  2. use display with utf8path

    @koivunej
    koivunej committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    89cb5f9 View commit details
    Browse the repository at this point in the history

  3. fix: less racy tasktracker usage

    @koivunej
    koivunej committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    12e72f6 View commit details
    Browse the repository at this point in the history

  4. test: remove unused fixture

    @koivunej
    koivunej committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    773d215 View commit details
    Browse the repository at this point in the history

  5. test: sprinkle graceful shutdowns 

    by default we do an immediate shutdown, which is not great if you want
to make sure some cleanup gets to run.
    @koivunej
    koivunej committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    6e6f5b2 View commit details
    Browse the repository at this point in the history

  6. more graceful stop

    @koivunej
    koivunej committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    731f97e View commit details
    Browse the repository at this point in the history