fix: stop leaking BackgroundPurges #8650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid "leaking" the completions of BackgroundPurges by: 1. switching it to TaskTracker for provided close+wait 2. stop using tokio::fs::remove_dir_all which will consume two units of memory instead of one std::fs::remove_dir_all
arpad-m
reviewed
Aug 8, 2024
|
I am not exactly sure which tests touch this, I am hoping some do. Need to check if tenant deletion tests actually shuts down pageserver gracefully. |
arpad-m
approved these changes
Aug 8, 2024
2112 tests run: 2043 passed, 0 failed, 69 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
731f97e at 2024-08-08T11:02:23.199Z :recycle: |
by default we do an immediate shutdown, which is not great if you want to make sure some cleanup gets to run.
jcsp
pushed a commit
that referenced
this pull request
Aug 12, 2024
avoid "leaking" the completions of BackgroundPurges by: 1. switching it to TaskTracker for provided close+wait 2. stop using tokio::fs::remove_dir_all which will consume two units of memory instead of one blocking task Additionally, use more graceful shutdown in tests which do actually some background cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid "leaking" the completions of BackgroundPurges by:
Additionally, use more graceful shutdown in tests which do actually some background cleanup.