Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.4] Add event for registering custom special block model renderers #1777

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

XFactHD
Copy link
Member

@XFactHD XFactHD commented Dec 15, 2024

This PR adds an event for attaching custom SpecialModelRenderers to blocks which render a part of or their entire model in a BER (i.e. blocks like chests, signs, skulls, shulker boxes, banners and beds). These SpecialModelRenderers are used via BlockRenderDispatcher#renderSingleBlock() when such a block is rendered in a minecart, as a display entity, on the back of a mushroom cow, in the iron golem's hand or in the enderman's hands.

@XFactHD XFactHD added enhancement New (or improvement to existing) feature or request rendering Related to rendering 1.21.4 Targeted at Minecraft 1.21.4 labels Dec 15, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Dec 15, 2024

  • Publish PR to GitHub Packages

Last commit published: 85f82c304dc108da29d5cf702a2d484ee478fb7a.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1777' // https://github.com/neoforged/NeoForge/pull/1777
        url 'https://prmaven.neoforged.net/NeoForge/pr1777'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1777.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1777
cd NeoForge-pr1777
curl -L https://prmaven.neoforged.net/NeoForge/pr1777/net/neoforged/neoforge/21.4.28-beta-pr-1777-special_block_renderer/mdk-pr1777.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@marchermans marchermans merged commit 8ed5b50 into neoforged:1.21.x Dec 21, 2024
7 checks passed
@XFactHD XFactHD deleted the special_block_renderer branch December 21, 2024 19:12
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.4.35-beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.4 Targeted at Minecraft 1.21.4 enhancement New (or improvement to existing) feature or request rendering Related to rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants