Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.21.4 #211

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

ChampionAsh5357
Copy link
Contributor

@ChampionAsh5357 ChampionAsh5357 commented Dec 3, 2024

Applies the contribution formatting and updates the docs to 1.21.4.

Waiting For

neoforged/NeoForge#1777
neoforged/NeoForge#1725

Closes

Closes #213
Closes #212
Supercedes #214

Subsections

  • Advanced
  • Block Entities
  • Blocks
  • Concepts
  • Data Storage
  • Getting Started
  • GUI
  • Items
  • Legacy
  • Misc
  • Networking
  • Resources
    • Client
      • Items (new)
      • Models
        • Datagen (Wait on 1725)
    • Server
      • Data Maps
      • Enchantments
      • Loot Tables
      • Recipes
  • World Generation

Preview URL: https://pr-211.neoforged-docs-previews.pages.dev

@ChampionAsh5357 ChampionAsh5357 added update Previously correct, but now outdated information. large Major additions or changes. labels Dec 3, 2024
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 3, 2024 21:25 Active
@neoforged-pages-deployments
Copy link

neoforged-pages-deployments bot commented Dec 3, 2024

Deploying with Cloudflare Pages

Name Result
Last commit: 96ed2f7a784478bec05ef26ac65e0e30169099af
Status: ✅ Deploy successful!
Preview URL: https://3b371ebb.neoforged-docs-previews.pages.dev
PR Preview URL: https://pr-211.neoforged-docs-previews.pages.dev

@IchHabeHunger54 IchHabeHunger54 self-requested a review December 8, 2024 13:59
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 14, 2024 16:22 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 14, 2024 16:50 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 14, 2024 17:26 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 14, 2024 17:38 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 14, 2024 18:36 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 14, 2024 18:52 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 14, 2024 18:58 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 16, 2024 01:13 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 16, 2024 01:21 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 16, 2024 01:34 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 16, 2024 15:28 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 16, 2024 22:02 Active
Copy link
Member

@IchHabeHunger54 IchHabeHunger54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First look on the smaller articles seems fine, two grammar nitpicks. Haven't had a look at anything in the Models folder yet, though.

docs/misc/resourcelocation.md Outdated Show resolved Hide resolved
docs/items/armor.md Outdated Show resolved Hide resolved
Co-authored-by: IchHabeHunger54 <[email protected]>
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 20, 2024 00:15 Active
@ChampionAsh5357 ChampionAsh5357 marked this pull request as ready for review December 27, 2024 23:30
@ChampionAsh5357 ChampionAsh5357 requested review from IchHabeHunger54 and a team December 27, 2024 23:34
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 27, 2024 23:37 Active
Copy link
Member

@XFactHD XFactHD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to look over the model datagen and item model pages.

docs/resources/client/models/bakedmodel.md Outdated Show resolved Hide resolved
docs/resources/client/models/bakedmodel.md Outdated Show resolved Hide resolved
docs/resources/client/models/index.md Outdated Show resolved Hide resolved
docs/resources/client/models/index.md Outdated Show resolved Hide resolved
docs/resources/index.md Outdated Show resolved Hide resolved
docs/resources/client/models/modelloaders.md Outdated Show resolved Hide resolved
docs/resources/client/models/modelloaders.md Outdated Show resolved Hide resolved
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 29, 2024 17:19 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 29, 2024 17:30 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 29, 2024 17:38 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 29, 2024 17:42 Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Major additions or changes. update Previously correct, but now outdated information.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

level attachments have been supported for a while extra face data example is false and doesnt work.
3 participants