Sync code in onDestroyedByPushReaction to original

[sciwhiz12]

This PR fixes #1699 by synchronizing the code in IBlockExtension#onDestroyedByPushReaction to the original code from PistonBaseBlock (which was moved to the extension method).

Particularly, the flags passed to Level#setBlock is now a constant 18, which is the combination of Block#UPDATE_KNOWN_SHAPE and Block#UPDATE_CLIENTS.

Tested with the same reproduction steps in the linked issue, and the fix works as the sign does not pop off on piston push.

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

Last commit published: bc5badea80e5f8197674c7101d4aa74cf1a6b942.

PR Publishing

The artifacts published by this PR:

• 📦 net.neoforged:testframework:21.4.16-beta-pr-1752-1.21-GH-1699-moss-block-sign-piston
• 📦 net.neoforged:neoforge:21.4.16-beta-pr-1752-1.21-GH-1699-moss-block-sign-piston

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1752' // https://github.com/neoforged/NeoForge/pull/1752
        url 'https://prmaven.neoforged.net/NeoForge/pr1752'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1752.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1752
cd NeoForge-pr1752
curl -L https://prmaven.neoforged.net/NeoForge/pr1752/net/neoforged/neoforge/21.4.16-beta-pr-1752-1.21-GH-1699-moss-block-sign-piston/mdk-pr1752.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

[neoforged-releases]

🚀 This PR has been released as NeoForge version 21.4.16-beta.