Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes param in cmd-parser to take escaped strings too #309

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

anderson4j
Copy link
Collaborator

@anderson4j anderson4j commented Dec 6, 2024

Cypher5/25Parser.g4 define
parameter[String paramType]
: DOLLAR parameterName[paramType]
;

parameterName[String paramType]
: (symbolicNameString | UNSIGNED_DECIMAL_INTEGER)
;

In CypherCmdParser.g4 instead we had:
paramsCmd: PARAM paramsArgs?;

paramsArgs: (CLEAR | listCompletionRule | map | lambda);

lambda: unescapedSymbolicNameString EQ GT expression;

So params created with lambda could never be escaped, even though regular parser allows it. this aligns cmd-parser with regular.

Copy link

changeset-bot bot commented Dec 6, 2024

⚠️ No Changeset found

Latest commit: fe1f775

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

…main parser does, and modified usage ib parseWrapper to fit
…rized rules are used yet, so I used parameterName["ANY"] for now
@anderson4j anderson4j marked this pull request as ready for review December 10, 2024 10:24
@anderson4j anderson4j requested a review from ncordon December 10, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants